Skip to content

Commit c35958c

Browse files
committed
Warn users about 20GiB COPY Docker bug
See #99
1 parent bed211c commit c35958c

File tree

3 files changed

+22
-3
lines changed

3 files changed

+22
-3
lines changed

ue4docker/build.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ def build():
237237
)
238238
sys.exit(1)
239239
elif newer_check is None:
240-
logger.info(
240+
logger.warning(
241241
"Warning: unable to determine whether host system is new enough to use specified base tag"
242242
)
243243

ue4docker/diagnostics/diagnostic_20gig.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,8 @@ def getDescription(self):
4040
return "\n".join(
4141
[
4242
"This diagnostic determines if the Docker daemon suffers from 20GiB COPY bug",
43-
"reported at https://github.com/moby/moby/issues/37352 (affects Windows containers only)",
4443
"",
45-
"#37352 was fixed in https://github.com/moby/moby/pull/41636 but that fix was not released yet",
44+
"See https://github.com/adamrehn/ue4-docker/issues/99#issuecomment-1079702817 for details and workarounds",
4645
"",
4746
self._parser.format_help(),
4847
]

ue4docker/infrastructure/BuildConfiguration.py

+20
Original file line numberDiff line numberDiff line change
@@ -530,6 +530,26 @@ def __init__(self, parser, argv, logger):
530530
"templates": ExcludedComponent.Templates in self.excludedComponents,
531531
}
532532

533+
# Warn user that they are in danger of Docker 20GB COPY bug
534+
# Unfortunately, we don't have a cheap way to check whether user environment is affected
535+
# See https://github.com/adamrehn/ue4-docker/issues/99
536+
if self.containerPlatform == "windows":
537+
if ExcludedComponent.Debug not in self.excludedComponents:
538+
logger.warning("Warning: You didn't pass --exclude debug", False)
539+
if not self.custom and semver.VersionInfo.parse(
540+
self.release
541+
) >= semver.VersionInfo(5, 0):
542+
logger.warning("Warning: You're building Unreal Engine 5", False)
543+
544+
logger.warning("Warning: You might hit Docker 20GiB COPY bug", False)
545+
logger.warning(
546+
"Warning: Make sure that `ue4-docker diagnostics 20gig` passes", False
547+
)
548+
logger.warning(
549+
"Warning: See https://github.com/adamrehn/ue4-docker/issues/99#issuecomment-1079702817 for details and workarounds",
550+
False,
551+
)
552+
533553
# If we're building Windows containers, generate our Windows-specific configuration settings
534554
if self.containerPlatform == "windows":
535555
self._generateWindowsConfig()

0 commit comments

Comments
 (0)