Skip to content

feat: send notification for joining/leaving an engagement (resolves #2578) #2614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 18, 2025

Conversation

jobara
Copy link
Collaborator

@jobara jobara commented Mar 31, 2025

Resolves #2578

  • Sends a notification to an individual when they join an engagement
  • Sends a notification to an individual when they leave an engagement
  • Added tests

Prerequisites

If this PR changes PHP code or dependencies:

  • I've run composer format and fixed any code formatting issues.
  • I've run composer analyze and addressed any static analysis issues.
  • I've run php artisan test and ensured that all tests pass.
  • I've run composer localize to update localization source files and committed any changes.

If this PR changes CSS or JavaScript code or dependencies:

  • I've run npm run lint and fixed any linting issues.
  • I've run npm run build and ensured that CSS and JavaScript assets can be compiled.

@jobara jobara added this to the 1.7.0 milestone Mar 31, 2025
@jobara jobara requested a review from greatislander March 31, 2025 19:00
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.27%. Comparing base (fd4bf38) to head (1880fdd).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #2614      +/-   ##
============================================
+ Coverage     97.25%   97.27%   +0.02%     
- Complexity     2290     2302      +12     
============================================
  Files           345      349       +4     
  Lines         10403    10511     +108     
============================================
+ Hits          10117    10225     +108     
  Misses          286      286              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jobara jobara moved this to In Progress in Public Launch Apr 3, 2025
@greatislander greatislander merged commit 7f09708 into accessibility-exchange:dev Apr 18, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Public Launch Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Send notification for joining an engagement
2 participants