-
Notifications
You must be signed in to change notification settings - Fork 9
feat: notifications for new engagements (resolves #2562) #2604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2604 +/- ##
============================================
- Coverage 97.27% 97.22% -0.06%
- Complexity 2302 2326 +24
============================================
Files 349 353 +4
Lines 10511 10531 +20
============================================
+ Hits 10225 10239 +14
- Misses 286 292 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I'm wondering if it might make sense to write a migration which would handle updating the notification settings as described in the PR description.
@greatislander and I discussed this. The new idea is to create a generic settings migration console command. This would run the data migration as mentioned the description above, it would also provide documentation for the change including the issue and PR it's related to. |
@greatislander I've pushed up the changes to add a console command for the migration step. However, I still need to add tests for it. I'm also running into some larastan complaints related to the console command, but all the cases where it is complaining are valid. Not sure what the appropriate work around or declaration is for those. |
@greatislander this is ready for review. I've added new tests for the console command (had to change the output for list to get the tests to work), add some docs to the readme, added the console command to be run on deploy. |
63f5233
into
accessibility-exchange:dev
Resolves #2562
TODO:
After releasing and deploying to staging and production the following should be run to update users and orgs. It will replace the existing
notification_settings
with one where the engagement notifications are on by default. It will also remove all othernotifications_settings
that may have been set before as they are no longer supported.Instead of the following methods for individual users and organizations, this console command can be run instead.
Individual Users
Organizations
Prerequisites
If this PR changes PHP code or dependencies:
composer format
and fixed any code formatting issues.composer analyze
and addressed any static analysis issues.php artisan test
and ensured that all tests pass.composer localize
to update localization source files and committed any changes.If this PR changes CSS or JavaScript code or dependencies:
npm run lint
and fixed any linting issues.npm run build
and ensured that CSS and JavaScript assets can be compiled.