Fixed issue with bk business ; Fixed issue with VersionHelper

Author: acadet

Gruntfile.js

@@ -7,6 +7,7 @@ module.exports = function (grunt) {
     grunt.loadNpmTasks("grunt-mkdir");
     grunt.loadNpmTasks("grunt-zip");
     grunt.loadNpmTasks("grunt-node-webkit-builder");
+    grunt.loadNpmTasks("grunt-contrib-uglify");
 
     // Configure grunt here
     grunt.initConfig({
@@ -166,7 +167,19 @@ module.exports = function (grunt) {
 	    		mac_icns : 'release/src/logo.icns'
 	    	},
 	    	src : ['release/src/**/*']
-	    }
+	    },
+		uglify: {
+			release: {
+				options : {
+					compress : true,
+					mangle : false,
+					preserveComments : false
+				},
+				files: {
+					'release/src/app/ui/js/output.js' : ['release/src/app/ui/js/output.js']
+				}
+			}
+		}
 	});
 
 	grunt.registerTask('build', ['ts:build']);
@@ -178,6 +191,7 @@ module.exports = function (grunt) {
 			'ts:release',
 			'mkdir:release',
 			'copy:release',
+			'uglify:release',
 			'nodewebkit',
 			'zip:releaseWin',
 			'zip:releaseMac',

app/helpers/VersionHelper.ts

@@ -5,7 +5,7 @@ class VersionHelper {
 	//region Fields
 
 	private static _target : string = 'http://yimello.adriencadet.com/version';
-	private static _version : string = '0.1.2';
+	private static _version : string = '0.2.0';
 
 	//endregion Fields
 
@@ -21,16 +21,29 @@ class VersionHelper {
 
 	//region Public Methods
 
-	static isUpToDate(callback : Action<boolean>) : void {
+	static isUpToDate(callback : Action<boolean>, errorHandler : Action<string> = null) : void {
 		var get : GetRequest;
 
-		get = new GetRequest(VersionHelper._target);
-		get.setDataType(AjaxRequestDataType.Text);
-		get.execute(
-			(data, status, xhr) => {
-				callback(data === VersionHelper._version);
+		if (Environment.isOnline()) {
+			get = new GetRequest(VersionHelper._target);
+			get.setDataType(AjaxRequestDataType.Text);
+			get.setErrorHandler(
+				(xhr, status, error) => {
+					if (TSObject.exists(errorHandler)) {
+						errorHandler(error);
+					}
+				}
+			);
+			get.execute(
+				(data, status, xhr) => {
+					callback(data === VersionHelper._version);
+				}
+			);
+		} else {
+			if (TSObject.exists(errorHandler)) {
+				errorHandler('Unable to check version: no connection was spotted');
 			}
-		);
+		}
 	}
 
 	//endregion Public Methods

app/models/business/impl/BookmarkBusiness.ts

@@ -75,12 +75,16 @@ class BookmarkBusiness implements IBookmarkBusiness {
 		bookmark.setURL(url);
 
 		title = bookmark.getTitle();
-		title = StringHelper.trim(title);
-		title = SecurityHelper.disarm(title);
-		if (title === '') {
+		if (!TSObject.exists(title) || title === '') {
 			bookmark.setTitle(bookmark.getURL());
 		} else {
-			bookmark.setTitle(title);
+			title = StringHelper.trim(title);
+			title = SecurityHelper.disarm(title);
+			if (title === '') {
+				bookmark.setTitle(bookmark.getURL());
+			} else {
+				bookmark.setTitle(title);
+			}
 		}
 
 		description = bookmark.getDescription();

package.json

@@ -8,16 +8,17 @@
     "height": 527,
     "resizable": false,
     "position": "center",
-    "icon" : "app/ui/assets/img/logo.png"
+    "icon": "app/ui/assets/img/logo.png"
   },
   "devDependencies": {
     "grunt": "~0.4.1",
     "grunt-ts": "~1.9.2",
     "typescript": "0.9.7",
     "grunt-contrib-copy": "~0.5.0",
-    "grunt-remove" : "0.1.0",
-    "grunt-mkdir" : "0.1.1",
-    "grunt-node-webkit-builder" : "0.1.21",
-    "grunt-zip" : "0.15.0"
+    "grunt-remove": "0.1.0",
+    "grunt-mkdir": "0.1.1",
+    "grunt-node-webkit-builder": "0.1.21",
+    "grunt-zip": "0.15.0",
+    "grunt-contrib-uglify": "~0.5.1"
   }
 }