Skip to content

Commit 3090362

Browse files
committed
Security improving ; Fixed issue with tour
1 parent 9b4b33f commit 3090362

File tree

2 files changed

+7
-10
lines changed

2 files changed

+7
-10
lines changed

app/models/business/impl/TagBookmarkBusiness.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,7 @@ class TagBookmarkBusiness implements ITagBookmarkBusiness {
204204
e = list[currentIndex];
205205
bookmark = BookmarkDAO.fromObject(e);
206206
BusinessMediator.getBookmarkBusiness().engineBookmark(bookmark);
207+
bookmark.setId(SecurityHelper.disarm(StringHelper.trim(bookmark.getId())));
207208
DataAccessObject.initialize(
208209
(success) => {
209210
ActiveRecordObject.insert(
@@ -231,6 +232,7 @@ class TagBookmarkBusiness implements ITagBookmarkBusiness {
231232
e = list[currentIndex];
232233
tag = TagDAO.fromObject(e);
233234
BusinessMediator.getTagBusiness().engineTag(tag);
235+
tag.setId(SecurityHelper.disarm(StringHelper.trim(tag.getId())));
234236
DataAccessObject.initialize(
235237
(success) => {
236238
ActiveRecordObject.insert(

app/presenters/TourPresenter.ts

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -123,13 +123,6 @@ class TourPresenter extends YimelloPresenter {
123123
return;
124124
}
125125

126-
if (!TSObject.exists(this._tags)) {
127-
// First call, gather data
128-
this._tags = DOMTree.findSingle('.js-slide .js-tag-list');
129-
TourPresenter._tagID = 0;
130-
this._currentTags = new ArrayList<TagDAO>();
131-
}
132-
133126
// Start to build a new tag
134127
tag =
135128
DOMElement.fromString('<li><p>' + value + '</p></li>');
@@ -212,9 +205,11 @@ class TourPresenter extends YimelloPresenter {
212205
* Prepares tag generator
213206
*/
214207
private _prepareTagGenerator() : void {
215-
if (!TSObject.exists(this._tagInput)) {
216-
this._tagInput = this._slides.findSingle('.js-slide .js-tag-form input[name="tags"]');
217-
}
208+
this._tagInput = this._slides.findSingle('.js-slide .js-tag-form input[name="tags"]');
209+
this._tags = DOMTree.findSingle('.js-slide .js-tag-list');
210+
TourPresenter._tagID = 0;
211+
this._currentTags = new ArrayList<TagDAO>();
212+
218213
this._tagInput.on(
219214
DOMElementEvents.KeyDown,
220215
(e) => {

0 commit comments

Comments
 (0)