ci: enable gocritic in golangci (#1223)

Author: PascalBourdier

.golangci.yml

@@ -0,0 +1,3 @@
+linters:
+  enable:
+    - gocritic

app/app.go

@@ -407,8 +407,7 @@ func (c colimaApp) Version() error {
 
 	var kube environment.Container
 	for _, cont := range containerRuntimes {
-		switch cont.Name() {
-		case kubernetes.Name:
+		if cont.Name() == kubernetes.Name {
 			kube = cont
 			continue
 		}

environment/container/docker/daemon.go

@@ -58,13 +58,13 @@ func (d dockerRuntime) createDaemonFile(conf map[string]any, env map[string]stri
 			return err
 		}
 		if vars.http != "" {
-			proxyConf["http-proxy"] = strings.Replace(vars.http, "127.0.0.1", hostGatewayIP, -1)
+			proxyConf["http-proxy"] = strings.ReplaceAll(vars.http, "127.0.0.1", hostGatewayIP)
 		}
 		if vars.https != "" {
-			proxyConf["https-proxy"] = strings.Replace(vars.https, "127.0.0.1", hostGatewayIP, -1)
+			proxyConf["https-proxy"] = strings.ReplaceAll(vars.https, "127.0.0.1", hostGatewayIP)
 		}
 		if vars.no != "" {
-			proxyConf["no-proxy"] = strings.Replace(vars.no, "127.0.0.1", hostGatewayIP, -1)
+			proxyConf["no-proxy"] = strings.ReplaceAll(vars.no, "127.0.0.1", hostGatewayIP)
 		}
 		conf["proxies"] = proxyConf
 	}

environment/container/kubernetes/kubernetes.go

@@ -246,9 +246,7 @@ func (c kubernetesRuntime) Teardown(ctx context.Context) error {
 
 	// k3s is buggy with external containerd for now
 	// cleanup is manual
-	a.Add(func() error {
-		return c.deleteAllContainers()
-	})
+	a.Add(c.deleteAllContainers)
 
 	c.teardownKubeconfig(a)
 

util/terminal/output.go

@@ -66,7 +66,7 @@ func (v *verboseWriter) refresh() error {
 }
 
 func (v *verboseWriter) addLine() {
-	defer v.buf.Truncate(0)
+	defer v.buf.Reset()
 
 	// if height <=0, do not scroll
 	if v.lineHeight <= 0 {