add i18n and address comments

Signed-off-by: abbyhu2000 <[email protected]>

Author: abbyhu2000

src/core/public/chrome/recently_accessed/recently_accessed_service.ts

@@ -40,7 +40,7 @@ export interface ChromeRecentlyAccessedHistoryItem {
   label: string;
   id: string;
   type?: string;
-  updatedAt?: string;
+  updatedAt?: number;
 }
 
 interface StartDeps {
@@ -58,7 +58,14 @@ export class RecentlyAccessedService {
 
     return {
       /** Adds a new item to the history. */
-      add: (link: string, label: string, id: string, type?: string, updatedAt?: string) => {
+      add: (
+        link: string,
+        label: string,
+        id: string,
+        extraProps: { type?: string; updatedAt?: number }
+      ) => {
+        const type = extraProps.type;
+        const updatedAt = extraProps.updatedAt;
         history.add({
           link,
           label,
@@ -96,7 +103,12 @@ export interface ChromeRecentlyAccessed {
    * @param type the item type
    * @param updatedAt the time that the item is last updated at
    */
-  add(link: string, label: string, id: string, type?: string, updatedAt?: string): void;
+  add(
+    link: string,
+    label: string,
+    id: string,
+    extraProps: { type?: string; updatedAt?: number }
+  ): void;
 
   /**
    * Gets an Array of the current recently accessed history.

src/plugins/dashboard/public/application/utils/use/use_saved_dashboard_instance.ts

@@ -6,7 +6,6 @@
 import { i18n } from '@osd/i18n';
 import { EventEmitter } from 'events';
 import { useEffect, useRef, useState } from 'react';
-import moment from 'moment';
 import {
   redirectWhenMissing,
   SavedObjectNotFound,
@@ -131,8 +130,7 @@ export const useSavedDashboardInstance = ({
               savedDashboard.getFullPath(),
               savedDashboard.title,
               dashboardIdFromUrl,
-              savedDashboard.getOpenSearchType(),
-              moment(Date.now()).format('MM/DD/YYYY HH:mm')
+              { type: savedDashboard.getOpenSearchType(), updatedAt: Date.now() }
             );
             setSavedDashboardInstance(dashboardInstance);
           } catch (error: any) {

src/plugins/discover/public/application/view_components/utils/use_search.ts

@@ -10,7 +10,6 @@ import { i18n } from '@osd/i18n';
 import { useEffect } from 'react';
 import { cloneDeep } from 'lodash';
 import { useLocation } from 'react-router-dom';
-import moment from 'moment';
 import { RequestAdapter } from '../../../../../inspector/public';
 import { DiscoverViewServices } from '../../../build_services';
 import { search } from '../../../../../data/public';
@@ -311,8 +310,10 @@ export const useSearch = (services: DiscoverViewServices) => {
           savedSearchInstance.getFullPath(),
           savedSearchInstance.title,
           savedSearchInstance.id,
-          savedSearchInstance.getOpenSearchType(),
-          moment(Date.now()).format('MM/DD/YYYY HH:mm')
+          {
+            type: savedSearchInstance.getOpenSearchType(),
+            updatedAt: Date.now(),
+          }
         );
       }
     })();

src/plugins/home/public/application/components/homepage/sections/recent_work.tsx

@@ -62,7 +62,9 @@ const render = renderFn(() => {
               <EuiFlexItem>
                 <EuiCard
                   layout="horizontal"
-                  title={recentAccessItem.label}
+                  title={i18n.translate('homepage.recentWorkSection.title', {
+                    defaultMessage: recentAccessItem.label,
+                  })}
                   titleSize="xs"
                   description={
                     <>
@@ -71,9 +73,14 @@ const render = renderFn(() => {
                         className="recent-work-title-icon"
                         type={recentWorkItem[0].icon}
                       />
-                      {recentWorkItem[0].name}
+                      {i18n.translate('homepage.recentWorkSection.name', {
+                        defaultMessage: recentWorkItem[0].name,
+                      })}
                       <br />
-                      {'Last updated ' + moment(recentAccessItem?.updatedAt).fromNow()}
+                      {i18n.translate('homepage.recentWorkSection.updatedAt', {
+                        defaultMessage:
+                          'Last updated ' + moment(recentAccessItem?.updatedAt).fromNow(),
+                      })}
                     </>
                   }
                   onClick={() => navigateToUrl(services.addBasePath(recentAccessItem.link))}

src/plugins/vis_builder/public/application/utils/use/use_saved_vis_builder_vis.ts

@@ -5,7 +5,6 @@
 
 import { i18n } from '@osd/i18n';
 import { useEffect, useState } from 'react';
-import moment from 'moment';
 import { SavedObject } from '../../../../../saved_objects/public';
 import {
   InvalidJSONProperty,
@@ -79,8 +78,7 @@ export const useSavedVisBuilderVis = (visualizationIdFromUrl: string | undefined
             savedVisBuilderVis.getFullPath(),
             title,
             savedVisBuilderVis.id,
-            savedVisBuilderVis.getOpenSearchType(),
-            moment(Date.now()).format('MM/DD/YYYY HH:mm')
+            { type: savedVisBuilderVis.getOpenSearchType(), updatedAt: Date.now() }
           );
 
           dispatch(setUIStateState(state.ui));

src/plugins/visualize/public/application/utils/use/use_saved_vis_instance.ts

@@ -32,7 +32,6 @@ import { useEffect, useRef, useState } from 'react';
 import { EventEmitter } from 'events';
 import { parse } from 'query-string';
 import { i18n } from '@osd/i18n';
-import moment from 'moment';
 
 import { redirectWhenMissing } from '../../../../../opensearch_dashboards_utils/public';
 import { DefaultEditorController } from '../../../../../vis_default_editor/public';
@@ -106,8 +105,7 @@ export const useSavedVisInstance = (
               savedVisInstance.savedVis.getFullPath(),
               savedVisInstance.savedVis.title,
               visualizationIdFromUrl,
-              savedVisInstance.savedVis.getOpenSearchType(),
-              moment(Date.now()).format('MM/DD/YYYY HH:mm')
+              { type: savedVisInstance.savedVis.getOpenSearchType(), updatedAt: Date.now() }
             );
           }
         }