Skip to content

Commit c637ee5

Browse files
Zen-cronicpichlermarc
authored andcommitted
refactor(examples/otlp-exporter-node): use new exported string constants for semconv (open-telemetry#4762)
* refactor(examples/otlp-exporter-node): use new exported string constants for semconv * added changelog entry --------- Co-authored-by: Marc Pichler <[email protected]>
1 parent c32006c commit c637ee5

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

CHANGELOG.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@ For experimental package changes, see the [experimental CHANGELOG](experimental/
2727
### :books: (Refine Doc)
2828

2929
* refactor(examples): use new exported string constants for semconv in examples/http [#4750](https://github.com/open-telemetry/opentelemetry-js/pull/4750) @Zen-cronic
30-
* refactor(examples): use new exported string constants for semconv in examples/opentracing-shim-semconv [#4761](https://github.com/open-telemetry/opentelemetry-js/pull/4761) @Zen-cronic
30+
* refactor(examples): use new exported string constants for semconv in examples/otlp-exporter-node [#4762](https://github.com/open-telemetry/opentelemetry-js/pull/4762) @Zen-cronic
31+
* refactor(examples): use new exported string constants for semconv in examples/opentracing-shim [#4761](https://github.com/open-telemetry/opentelemetry-js/pull/4761) @Zen-cronic
3132

3233
### :house: (Internal)
3334

examples/otlp-exporter-node/metrics.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ const {
1313
} = require('@opentelemetry/sdk-metrics');
1414
const { Resource } = require('@opentelemetry/resources');
1515
const {
16-
SemanticResourceAttributes,
16+
SEMRESATTRS_SERVICE_NAME,
1717
} = require('@opentelemetry/semantic-conventions');
1818

1919
// Optional and only needed to see the internal diagnostic logging (during development)
@@ -36,7 +36,7 @@ const expHistogramView = new View({
3636
// Create an instance of the metric provider
3737
const meterProvider = new MeterProvider({
3838
resource: new Resource({
39-
[SemanticResourceAttributes.SERVICE_NAME]: 'basic-metric-service',
39+
[SEMRESATTRS_SERVICE_NAME]: 'basic-metric-service',
4040
}),
4141
views: [expHistogramView],
4242
});

examples/otlp-exporter-node/tracing.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
const { BasicTracerProvider, ConsoleSpanExporter, SimpleSpanProcessor } = require('@opentelemetry/sdk-trace-base');
44
const { Resource } = require('@opentelemetry/resources');
5-
const { SemanticResourceAttributes } = require('@opentelemetry/semantic-conventions');
5+
const { SEMRESATTRS_SERVICE_NAME } = require('@opentelemetry/semantic-conventions');
66
const {
77
diag,
88
trace,
@@ -24,7 +24,7 @@ const exporter = new OTLPTraceExporter({
2424

2525
const provider = new BasicTracerProvider({
2626
resource: new Resource({
27-
[SemanticResourceAttributes.SERVICE_NAME]: 'basic-service',
27+
[SEMRESATTRS_SERVICE_NAME]: 'basic-service',
2828
}),
2929
});
3030
provider.addSpanProcessor(new SimpleSpanProcessor(exporter));

0 commit comments

Comments
 (0)