Skip to content

Commit 1f01bdb

Browse files
trentmZirak
authored andcommitted
fix(instrumentation): drop diag.debug on InstrumentationBase#init not returning any modules (open-telemetry#4925)
1 parent 284ff9d commit 1f01bdb

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

experimental/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ All notable changes to experimental packages in this project will be documented
2626

2727
* fix(instrumentation-http): Ensure instrumentation of `http.get` and `https.get` work when used in ESM code [#4857](https://github.com/open-telemetry/opentelemetry-js/issues/4857) @trentm
2828
* fix(api-logs): align AnyValue to spec [#4893](https://github.com/open-telemetry/opentelemetry-js/pull/4893) @blumamir
29+
* fix(instrumentation): remove diag.debug() message for instrumentations that do not patch modules [#4925](https://github.com/open-telemetry/opentelemetry-js/pull/4925) @trentm
2930

3031
### :books: (Refine Doc)
3132

experimental/packages/opentelemetry-instrumentation/src/platform/node/instrumentation.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -66,14 +66,6 @@ export abstract class InstrumentationBase<
6666

6767
this._modules = (modules as InstrumentationModuleDefinition[]) || [];
6868

69-
if (this._modules.length === 0) {
70-
diag.debug(
71-
'No modules instrumentation has been defined for ' +
72-
`'${this.instrumentationName}@${this.instrumentationVersion}'` +
73-
', nothing will be patched'
74-
);
75-
}
76-
7769
if (this._config.enabled) {
7870
this.enable();
7971
}

0 commit comments

Comments
 (0)