fixing a bug where account creation is not triggered in firefox when comparing string values from ldap as integer

Barry de Graaff · Barry de Graaff · commit 07b5012fc5ee · 2020-02-17T10:30:33.000+01:00
diff --git a/zimlet/com_zimbra_rocket/com_zimbra_rocket.js b/zimlet/com_zimbra_rocket/com_zimbra_rocket.js
@@ -21,7 +21,7 @@ ZimbraRocketZimlet.prototype.init = function () {
    
       if(zimletInstance.createRocketAccount == "true")
       {
-         if(zimletInstance.accountCreateInteger > zimletInstance.userAccountCreateInteger)
+         if(parseInt(zimletInstance.accountCreateInteger) > parseInt(zimletInstance.userAccountCreateInteger))
          {
             zimletInstance.setUserProperty("accountCreateInteger", zimletInstance.accountCreateInteger, true);
             ZimbraRocketZimlet.prototype.createAccount();

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ ZimbraRocketZimlet.prototype.init = function () {`
`21`	`21`
`22`	`22`	`if(zimletInstance.createRocketAccount == "true")`
`23`	`23`	`{`
`24`		`- if(zimletInstance.accountCreateInteger > zimletInstance.userAccountCreateInteger)`
	`24`	`+ if(parseInt(zimletInstance.accountCreateInteger) > parseInt(zimletInstance.userAccountCreateInteger))`
`25`	`25`	`{`
`26`	`26`	`zimletInstance.setUserProperty("accountCreateInteger", zimletInstance.accountCreateInteger, true);`
`27`	`27`	`ZimbraRocketZimlet.prototype.createAccount();`