fix lifetime of skyinfo variable in HWWall::SkyPlane.

coelckers · coelckers · commit d45a4f18d46f · 2024-04-22T07:14:04.000+02:00
diff --git a/src/rendering/hwrenderer/scene/hw_sky.cpp b/src/rendering/hwrenderer/scene/hw_sky.cpp
@@ -137,9 +137,9 @@ void HWWall::SkyPlane(HWWallDispatcher *di, sector_t *sector, int plane, bool al
 	// Either a regular sky or a skybox with skyboxes disabled
 	if ((sportal == nullptr && sector->GetTexture(plane) == skyflatnum) || (gl_noskyboxes && sportal != nullptr && sportal->mType == PORTS_SKYVIEWPOINT))
 	{
+		HWSkyInfo skyinfo;
 		if (di->di)
 		{
-			HWSkyInfo skyinfo;
 			skyinfo.init(di->di, sector, plane, sector->skytransfer, Colormap.FadeColor);
 			ptype = PORTALTYPE_SKY;
 			sky = &skyinfo;

Original file line number	Diff line number	Diff line change
`@@ -137,9 +137,9 @@ void HWWall::SkyPlane(HWWallDispatcher di, sector_t sector, int plane, bool al`
`137`	`137`	`// Either a regular sky or a skybox with skyboxes disabled`
`138`	`138`	`if ((sportal == nullptr && sector->GetTexture(plane) == skyflatnum) \|\| (gl_noskyboxes && sportal != nullptr && sportal->mType == PORTS_SKYVIEWPOINT))`
`139`	`139`	`{`
	`140`	`+ HWSkyInfo skyinfo;`
`140`	`141`	`if (di->di)`
`141`	`142`	`{`
`142`		`- HWSkyInfo skyinfo;`
`143`	`143`	`skyinfo.init(di->di, sector, plane, sector->skytransfer, Colormap.FadeColor);`
`144`	`144`	`ptype = PORTALTYPE_SKY;`
`145`	`145`	`sky = &skyinfo;`