Small correction to OoB viewpoint stacked-sector portal visibility. OoB is not the same as Ortho.

dileepvr · RicardoLuis0 · commit 5ba6bd204f3d · 2025-04-09T14:19:56.000-03:00
diff --git a/src/rendering/hwrenderer/scene/hw_sky.cpp b/src/rendering/hwrenderer/scene/hw_sky.cpp
@@ -157,7 +157,9 @@ void HWWall::SkyPlane(HWWallDispatcher *di, sector_t *sector, int plane, bool al
 			if (di->di && di->di->Viewpoint.IsAllowedOoB())
 			{
 				secplane_t myplane = plane ? sector->ceilingplane : sector->floorplane;
-				if (di->di->Viewpoint.ViewVector3D.dot(myplane.Normal()) > 0.0) return;
+				if (di->di->Viewpoint.IsOrtho() && di->di->Viewpoint.ViewVector3D.dot(myplane.Normal()) > 0.0) return;
+				else if (plane==1 && di->di->Viewpoint.Pos.Z >= myplane.ZatPoint(di->di->Viewpoint.Pos)) return;
+				else if (plane==0 && di->di->Viewpoint.Pos.Z <= myplane.ZatPoint(di->di->Viewpoint.Pos)) return;
 			}
 			auto glport = sector->GetPortalGroup(plane);
 			if (glport != NULL)

Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,9 @@ void HWWall::SkyPlane(HWWallDispatcher di, sector_t sector, int plane, bool al`
`157`	`157`	`if (di->di && di->di->Viewpoint.IsAllowedOoB())`
`158`	`158`	`{`
`159`	`159`	`secplane_t myplane = plane ? sector->ceilingplane : sector->floorplane;`
`160`		`- if (di->di->Viewpoint.ViewVector3D.dot(myplane.Normal()) > 0.0) return;`
	`160`	`+ if (di->di->Viewpoint.IsOrtho() && di->di->Viewpoint.ViewVector3D.dot(myplane.Normal()) > 0.0) return;`
	`161`	`+ else if (plane==1 && di->di->Viewpoint.Pos.Z >= myplane.ZatPoint(di->di->Viewpoint.Pos)) return;`
	`162`	`+ else if (plane==0 && di->di->Viewpoint.Pos.Z <= myplane.ZatPoint(di->di->Viewpoint.Pos)) return;`
`161`	`163`	`}`
`162`	`164`	`auto glport = sector->GetPortalGroup(plane);`
`163`	`165`	`if (glport != NULL)`