Remove bitwise opeartion on bool

dileepvr · RicardoLuis0 · commit 40aef53e266f · 2025-04-09T14:28:10.000-03:00
Visual Studio compiler was giving the warning:
`warning C4805: '|=': unsafe mix of type 'bool' and type 'int' in operation`
diff --git a/src/rendering/hwrenderer/scene/hw_walls.cpp b/src/rendering/hwrenderer/scene/hw_walls.cpp
@@ -85,7 +85,7 @@ void HWWall::RenderWall(FRenderState &state, int textured)
 {
 	bool ditherT = (type == RENDERWALL_BOTTOM) && (seg->sidedef->Flags & WALLF_DITHERTRANS_BOTTOM);
 	ditherT |= (type == RENDERWALL_TOP) && (seg->sidedef->Flags & WALLF_DITHERTRANS_TOP);
-	ditherT |= seg->sidedef->Flags & WALLF_DITHERTRANS_MID;
+	ditherT = ditherT || (seg->sidedef->Flags & WALLF_DITHERTRANS_MID);
 	if (ditherT)
 	{
 		state.SetEffect(EFF_DITHERTRANS);

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ void HWWall::RenderWall(FRenderState &state, int textured)`
`85`	`85`	`{`
`86`	`86`	`bool ditherT = (type == RENDERWALL_BOTTOM) && (seg->sidedef->Flags & WALLF_DITHERTRANS_BOTTOM);`
`87`	`87`	`ditherT \|= (type == RENDERWALL_TOP) && (seg->sidedef->Flags & WALLF_DITHERTRANS_TOP);`
`88`		`- ditherT \|= seg->sidedef->Flags & WALLF_DITHERTRANS_MID;`
	`88`	`+ ditherT = ditherT \|\| (seg->sidedef->Flags & WALLF_DITHERTRANS_MID);`
`89`	`89`	`if (ditherT)`
`90`	`90`	`{`
`91`	`91`	`state.SetEffect(EFF_DITHERTRANS);`