Skip to content

App key should be saved #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tituspijean opened this issue Aug 11, 2023 · 2 comments
Open

App key should be saved #130

tituspijean opened this issue Aug 11, 2023 · 2 comments

Comments

@tituspijean
Copy link
Member

Describe the bug

bookstack_ynh/conf/.env.example.complete

Line 18 in d615c70

APP_KEY=SomeRandomString

This line is being overwritten during each upgrade. Let's store the key.
@ericgaspar
Copy link
Member

The key gets regenerated with

bookstack_ynh/scripts/upgrade

Line 98 in d615c70

php$phpversion artisan key:generate --force

Not really sure if it's a issue not to keep the same key.

@tituspijean
Copy link
Member Author

It's a feedback from a user who came to the Yunocamp, let's wait for his new test tonight.
I tested myself, and I indeed saw no issue while upgrading and changing the key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tituspijean @ericgaspar