Skip to content

Commit fc6d425

Browse files
committed
Update JavaDoc to reflect CRLDistributionPoints improvements
1 parent 811cd63 commit fc6d425

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

webauthn-server-attestation/src/main/java/com/yubico/fido/metadata/FidoMetadataDownloader.java

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -545,9 +545,9 @@ public FidoMetadataDownloaderBuilder clock(@NonNull Clock clock) {
545545
/**
546546
* Use the provided CRLs.
547547
*
548-
* <p>CRLs will also be downloaded from distribution points if the <code>
549-
* com.sun.security.enableCRLDP</code> system property is set to <code>true</code> (assuming the
550-
* use of the {@link CertPathValidator} implementation from the SUN provider).
548+
* <p>CRLs will also be downloaded from distribution points for any certificates with a
549+
* CRLDistributionPoints extension, if the extension can be successfully interpreted. A warning
550+
* message will be logged CRLDistributionPoints parsing fails.
551551
*
552552
* @throws InvalidAlgorithmParameterException if {@link CertStore#getInstance(String,
553553
* CertStoreParameters)} does.
@@ -563,9 +563,9 @@ public FidoMetadataDownloaderBuilder useCrls(@NonNull Collection<CRL> crls)
563563
/**
564564
* Use CRLs in the provided {@link CertStore}.
565565
*
566-
* <p>CRLs will also be downloaded from distribution points if the <code>
567-
* com.sun.security.enableCRLDP</code> system property is set to <code>true</code> (assuming the
568-
* use of the {@link CertPathValidator} implementation from the SUN provider).
566+
* <p>CRLs will also be downloaded from distribution points for any certificates with a
567+
* CRLDistributionPoints extension, if the extension can be successfully interpreted. A warning
568+
* message will be logged CRLDistributionPoints parsing fails.
569569
*
570570
* @see #useCrls(Collection)
571571
*/
@@ -693,7 +693,7 @@ public FidoMetadataDownloaderBuilder verifyDownloadsOnly(final boolean verifyDow
693693
* @throws InvalidAlgorithmParameterException if certificate path validation fails.
694694
* @throws InvalidKeyException if signature verification fails.
695695
* @throws NoSuchAlgorithmException if signature verification fails, or if the SHA-256 algorithm
696-
* is not available.
696+
* or the <code>"Collection"</code> type {@link CertStore} is not available.
697697
* @throws SignatureException if signature verification fails.
698698
* @throws UnexpectedLegalHeader if the downloaded BLOB (if any) contains a <code>"legalHeader"
699699
* </code> value not configured in {@link
@@ -796,7 +796,7 @@ public MetadataBLOB loadCachedBlob()
796796
* @throws InvalidAlgorithmParameterException if certificate path validation fails.
797797
* @throws InvalidKeyException if signature verification fails.
798798
* @throws NoSuchAlgorithmException if signature verification fails, or if the SHA-256 algorithm
799-
* is not available.
799+
* or the <code>"Collection"</code> type {@link CertStore} is not available.
800800
* @throws SignatureException if signature verification fails.
801801
* @throws UnexpectedLegalHeader if the downloaded BLOB (if any) contains a <code>"legalHeader"
802802
* </code> value not configured in {@link
@@ -968,7 +968,8 @@ private X509Certificate retrieveTrustRootCert()
968968
* @throws IOException on failure to parse the BLOB contents.
969969
* @throws InvalidAlgorithmParameterException if certificate path validation fails.
970970
* @throws InvalidKeyException if signature verification fails.
971-
* @throws NoSuchAlgorithmException if signature verification fails.
971+
* @throws NoSuchAlgorithmException if signature verification fails, or if the SHA-256 algorithm
972+
* or the <code>"Collection"</code> type {@link CertStore} is not available.
972973
* @throws SignatureException if signature verification fails.
973974
* @throws FidoMetadataDownloaderException if the explicitly configured BLOB (if any) has a bad
974975
* signature.

0 commit comments

Comments
 (0)