tests: added test that verifies that CommandChainingTransformTests stops sending data

Author: DennisDyallo

Yubico.YubiKey/tests/unit/Yubico/YubiKey/Pipelines/CommandChainingTransformTests.cs

@@ -153,6 +153,7 @@ public void Invoke_CommandApduWithLargeDataBuffer_OrsHex10ToClaOnAllExceptLast()
 
             _ = mockTransform
                 .Setup(x => x.Invoke(It.IsAny<CommandApdu>(), It.IsAny<Type>(), It.IsAny<Type>()))
+                .Returns(new ResponseApdu([], 0x90))
                 .Callback<CommandApdu, Type, Type>((a, b, c) => observedCla.Add(a.Cla));
 
             // Act
@@ -180,6 +181,7 @@ public void Invoke_CommandApduWithLargeDataBuffer_AllOtherApduPropertiesRemainUn
 
             _ = mockTransform
                 .Setup(x => x.Invoke(It.IsAny<CommandApdu>(), It.IsAny<Type>(), It.IsAny<Type>()))
+                .Returns(new ResponseApdu([], 0x90))
                 .Callback<CommandApdu, Type, Type>((a, b, c) => observedApdus.Add(a));
 
             // Act
@@ -209,6 +211,7 @@ public void Invoke_CommandApduWithLargeDataBuffer_SplitsDataAcrossInvokeCalls()
 
             _ = mockTransform
                 .Setup(x => x.Invoke(It.IsAny<CommandApdu>(), It.IsAny<Type>(), It.IsAny<Type>()))
+                .Returns(new ResponseApdu([], 0x90))
                 .Callback<CommandApdu, Type, Type>((a, b, c) => observedApdus.Add(a.Data.ToArray()));
 
             // Act
@@ -219,5 +222,34 @@ public void Invoke_CommandApduWithLargeDataBuffer_SplitsDataAcrossInvokeCalls()
             Assert.Equal(new byte[] { 5, 6, 7, 8 }, observedApdus[1]);
             Assert.Equal(new byte[] { 9, 10 }, observedApdus[2]);
         }
+        
+        [Fact]
+        public void Invoke_CommandApduWithLargeDataBuffer_DoesntProcessAllBytes()
+        {
+            var observedApdus = new List<byte[]>();
+
+            // Arrange
+            var mockTransform = new Mock<IApduTransform>();
+            var transform = new CommandChainingTransform(mockTransform.Object) { MaxChunkSize = 4 };
+            var commandApdu = new CommandApdu
+            {
+                Data = new byte[] { 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 }
+            };
+
+            _ = mockTransform
+                .Setup(x => x.Invoke(It.IsAny<CommandApdu>(), It.IsAny<Type>(), It.IsAny<Type>()))
+                .Returns(new ResponseApdu([], 0x6700))
+                .Callback<CommandApdu, Type, Type>((a, b, c) =>
+                {
+                    observedApdus.Add(a.Data.ToArray());
+                });
+
+            // Act
+            _ = transform.Invoke(commandApdu, typeof(object), typeof(object));
+
+            // Assert 
+            // Should only make one pass with 4 bytes, before exiting 
+            Assert.Equal(4, observedApdus[0].Length);
+        }
     }
 }