Skip to content

Commit a4c4df1

Browse files
committed
tests: added ability to select usbcbio
1 parent 4cb9c8e commit a4c4df1

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

Yubico.YubiKey/tests/utilities/Yubico/YubiKey/TestUtilities/IntegrationTestDeviceEnumeration.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,9 @@ public static IList<IYubiKeyDevice> GetTestDevices(
116116
.FindByTransport(transport)
117117
.Where(IsAllowedKey)
118118
.ToList();
119-
return devices;
119+
120+
return devices;
121+
120122
static bool IsAllowedKey(
121123
IYubiKeyDevice key)
122124
=> key.SerialNumber == null ||

Yubico.YubiKey/tests/utilities/Yubico/YubiKey/TestUtilities/TestDeviceSelection.cs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -89,22 +89,21 @@ public static IYubiKeyDevice SelectByStandardTestDevice(
8989
StandardTestDevice.Fw4Fips => SelectDevice(4, isFipsSeries: true),
9090
StandardTestDevice.Fw5 => SelectDevice(5),
9191
StandardTestDevice.Fw5Fips => SelectDevice(5, isFipsSeries: true),
92-
StandardTestDevice.Fw5Bio => SelectDevice(5, formFactor: FormFactor.UsbABiometricKeychain),
92+
StandardTestDevice.Fw5Bio => SelectDevice(5, [FormFactor.UsbCBiometricKeychain, FormFactor.UsbABiometricKeychain]),
9393
_ => throw new ArgumentException("Invalid test device value.", nameof(testDeviceType)),
9494
};
9595

9696
IYubiKeyDevice SelectDevice(
9797
int majorVersion,
98-
FormFactor? formFactor = null,
98+
IEnumerable<FormFactor>? formFactors = null,
9999
bool isFipsSeries = false)
100100
{
101101
IYubiKeyDevice device = null!;
102102
try
103103
{
104-
bool MatchingDeviceSelector(
105-
IYubiKeyDevice d) =>
104+
bool MatchingDeviceSelector(IYubiKeyDevice d) =>
106105
d.FirmwareVersion.Major == majorVersion &&
107-
(formFactor is null || d.FormFactor == formFactor) &&
106+
(formFactors is null || formFactors.Contains(d.FormFactor)) &&
108107
d.IsFipsSeries == isFipsSeries;
109108

110109
device = devicesVersionFiltered.First(MatchingDeviceSelector);

0 commit comments

Comments
 (0)