Skip to content

Commit 71e6fa9

Browse files
MarkusVolkkraj
authored andcommitted
cups-filters: Upgrade 1.28.17 -> 2.0.0
- `universal`: Enable `application/vnd.cups-postscript` as input There are filters which produce this MIME type (such as `hpps` of HPLIP), and if someone uses such driver on a client and the server has an IPP Everywhere/driverless printer, the job fails (Pull request openembedded#534). - beh backend: Use `execv()` instead of `system()` - CVE-2023-24805 With `execv()` command line arguments are passed as separate strings and not the full command line in a single string. This prevents arbitrary command execution by escaping the quoting of the arguments in a job with forged job title. - beh backend: Extra checks against odd/forged input - CVE-2023-24805 * Do not allow `/` in the scheme of the URI (= backend executable name), to assure that only backends inside `/usr/lib/cups/backend/` are used. * Pre-define scheme buffer to empty string, to be defined for case of URI being NULL. * URI must have `:`, to split off scheme, otherwise error. * Check return value of `snprintf()` to create call path for backend, to error out on truncation of a too long scheme or on complete failure due to a completely odd scheme. - beh backend: Further improvements - CVE-2023-24805 * Use `strncat()` instead of `strncpy()` for getting scheme from URI, the latter does not require setting terminating zero byte in case of truncation. * Also exclude `.` or `..` as scheme, as directories are not valid CUPS backends. * Do not use `fprintf()` in `sigterm_handler()`, to not interfere with a `fprintf()` which could be running in the main process when `sigterm_handler()` is triggered. * Use `static volatile int` for global variable job_canceled. - `parallel` backend: Added missing `#include` lines - foomatic-rip: Fix a SIGPIPE error when calling gs (Pull request openembedded#517) [Ubuntu's autopkgtest for foo2zjs](https://autopkgtest.ubuntu.com/packages/f/foo2zjs/lunar/ppc64el) shows foo2zjs's testsuite failing with cups-filters 2.0beta3 on ppc64el. This is cause by a timing issue in foomatic-rip which is fixed now. - Coverity check done by Zdenek Dohnal for the inclusion of cups-filters in Fedora and Red Hat. Zdenek has fixed all the issues: Missing `free()`, files not closed, potential string overflows, ... Thanks a lot! (Pull request openembedded#510). - Dropped all C++ references and obsolete C standards (Pull requests openembedded#504 and openembedded#513) With no C++ compiler needed, there is no need for any checks or setting for C++ in configure.ac. - configure.ac: Change deprecated AC_PROG_LIBTOOL for LT_INIT (Pull request openembedded#508) - texttopdf: Do not include fontconfig.h in the CUPS filter wrapper - Build system: Do not explicitly check for libpoppler-cpp The cups-filters package does not contain any code using libpoppler-cpp, therefore we let ./configure not check for it. - COPYING, NOTICE: Simplification for autotools-generated files autotools-generated files can be included under the license of the upstream code, and FSF copyright added to upstream copyright list. Simplified COPYING appropriately. - Makefile.am: Include LICENSE in distribution tarball - Add templates for issue reports on GitHub. This makes a selection screen appear when clicking "New Issue" in the web UI, to selct whether the issue is a regular bug, a feature request, or a security vulnerability. - Corrected installation path for *.h files of *.drv files. The ppdc (and underlying functions) of libppd searches for include files in /usr/share/ppdc and not in /usr/share/cups/ppdc any more. - configure.ac: Remove unnecessary "AVAHI_GLIB_..." definitions. - Makefile.am: Include NOTICE in distribution tarball - configure.ac: Added "foreign" to to AM_INIT_AUTOMAKE() call. Makes automake not require a file named README. - Cleaned up .gitignore - Tons of fixes in the source code documentation: README.md, INSTALL, DEVELOPING.md, CONTRIBUTING.md, COPYING, NOTICE, ... Adapted to the cups-filters component, added links. - Converted nearly all filters to filter functions, only exceptions are `rastertoescpx`, `rastertopclx`, `commandtoescpx`, `commandtopclx`, and `foomatic-rip`. The latter is deeply involved with Foomatic PPDs and the others are legacy printer drivers. The filter functions are mainly in libcupsfilters, the ones which generate PostScript are in libppd. - Replaced all the filters converted to filter functions by simple wrapper executables using `ppdFilterCUPSWrapper()` of libppd for backward compatibility with CUPS 2.x. - Added new streaming mode triggered by the boolean "filter-streaming-mode" option. In this mode a filter (function) is supposed to avoid everything which prevents the job data from streaming, as loading the whole job (or good part of it) into a temporary file or into memory, interpreting PDF, pre-checking input file type or zero-page jobs, ... This is mainly to be used by Printer Applications when they do raster printing in streaming mode, to run with lowest resources possible. Currently `foomatic-rip`, `ghostscript`, and `pdftopdf` got a streaming mode. For the former two PostScript (not PDF) is assumed as input and no zero-page-job check is done, in the latter all QPDF processing (page management, page size adjustment, ...) is skipped and only JCL according to the PPD added. - The CUPS filter `imagetops` uses the `ppdFilterImageToPS()` filter function of libppd now. - `driverless`, `driverless-fax`: Added IPP Fax Out support. Now printer setup tools list an additional fax "driver". A fax queue is created by selecting this driver. Jobs have to be sent with "-o phone=12345" to supply the destination phone number (Pull request openembedded#280, openembedded#293, openembedded#296, openembedded#302, openembedded#304, openembedded#305, openembedded#306, openembedded#309, Issue openembedded#298, openembedded#308). - `sys5ippprinter`: Removed `sys5ippprinter`, as CUPS does not support System V interface scripts any more. This first approach of PPD-less printing was also not actually made use of. - `urftopdf`: Removed as we require CUPS 2.2.2+ now which supports Apple Raster by itself. - Build system, `README.md`: Require CUPS 2.2.2+. Removed now unneeded `./configure` switches for use of the `urftopdf` filter for old CUPS versions. - Sample PPDs: Renamed source directory from `ppd/` to `ppdfiles/`. - Build system: Remove '-D_PPD_DEPRECATED=""' from the compiling command lines of the source files which use libcups. The flag is not supported any more for longer times already and all the PPD-related functions deprecated by CUPS have moved into libppd now. - Build system: Add files in `.gitignore` that are generated by "autogen.sh", "configure", and "make" (Pull request openembedded#336). Signed-off-by: Markus Volk <[email protected]> Signed-off-by: Khem Raj <[email protected]>
1 parent 3d7d598 commit 71e6fa9

File tree

5 files changed

+69
-91
lines changed

5 files changed

+69
-91
lines changed

meta-oe/recipes-printing/cups/cups-filters_1.28.17.bb

Lines changed: 0 additions & 84 deletions
This file was deleted.
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
DESCRIPTION = "CUPS backends, filters, and other software"
2+
HOMEPAGE = "http://www.linuxfoundation.org/collaborate/workgroups/openprinting/cups-filters"
3+
LICENSE = "Apache-2.0"
4+
LIC_FILES_CHKSUM = "file://COPYING;md5=6d5b952b53dbe7752199903d082e5f07"
5+
6+
DEPENDS = "libcupsfilters libppd glib-2.0 poppler"
7+
8+
SRC_URI = "https://github.com/OpenPrinting/${BPN}/releases/download/${PV}/${BP}.tar.xz"
9+
SRC_URI[sha256sum] = "b5152e3dd148ed73835827ac2f219df7cf5808dbf9dbaec2aa0127b44de800d8"
10+
11+
inherit autotools gettext pkgconfig github-releases
12+
13+
EXTRA_OECONF += " \
14+
--enable-imagefilters \
15+
--enable-ghostscript --with-gs-path=${bindir}/gs \
16+
--with-fontdir=${datadir}/fonts \
17+
--localstatedir=${localstatedir} \
18+
"
19+
20+
PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'zeroconf', 'avahi', '', d)}"
21+
PACKAGECONFIG[avahi] = "--enable-avahi,--disable-avahi,avahi"
22+
23+
FILES:${PN} += "${datadir}"
24+
FILES:${PN}-dev += "${datadir}/ppdc"
25+
26+
RDEPENDS:${PN} += "bash"
27+
RDEPENDS:${PN} += "ghostscript"
Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,22 +15,22 @@ Signed-off-by: Khem Raj <[email protected]>
1515
filter/pdftoraster.cxx | 4 ++++
1616
1 file changed, 4 insertions(+)
1717

18-
diff --git a/filter/pdftoraster.cxx b/filter/pdftoraster.cxx
18+
diff --git a/cupsfilters/pdftoraster.cxx b/cupsfilters/pdftoraster.cxx
1919
index e8af184fb..e91e22459 100755
20-
--- a/filter/pdftoraster.cxx
21-
+++ b/filter/pdftoraster.cxx
22-
@@ -2148,7 +2148,11 @@ int main(int argc, char *argv[]) {
23-
/* For compatibility with g++ >= 4.7 compilers _GLIBCXX_THROW
24-
* should be used as a guard, otherwise use traditional definition */
20+
@@ -2198,7 +2198,11 @@
21+
// For compatibility with g++ >= 4.7 compilers _GLIBCXX_THROW
22+
// should be used as a guard, otherwise use traditional definition
2523
#ifndef _GLIBCXX_THROW
24+
-#define _GLIBCXX_THROW throw
2625
+#if __cplusplus < 201703L
27-
#define _GLIBCXX_THROW throw
26+
+#define _GLIBCXX_THROW throw
2827
+#else
2928
+#define _GLIBCXX_THROW(x) noexcept(false)
3029
+#endif
3130
#endif
3231

3332
void * operator new(size_t size) _GLIBCXX_THROW (std::bad_alloc)
33+
3434
--
3535
2.39.1
3636

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
DESCRIPTION = "OpenPrinting libcupsfilters"
2+
HOMEPAGE = "https://github.com/OpenPrinting"
3+
LICENSE = "Apache-2.0"
4+
LIC_FILES_CHKSUM = "file://COPYING;md5=aab2024bd2a475438a154cd1640c9684"
5+
6+
DEPENDS = "cups fontconfig libexif dbus lcms qpdf poppler libpng jpeg tiff"
7+
8+
SRC_URI = " \
9+
https://github.com/OpenPrinting/${BPN}/releases/download/${PV}/${BP}.tar.xz \
10+
file://0001-use-noexcept-false-instead-of-throw-from-c-17-onward.patch \
11+
"
12+
SRC_URI[sha256sum] = "542f2bfbc58136a4743c11dc8c86cee03c9aca705612654e36ac34aa0d9aa601"
13+
14+
inherit autotools gettext pkgconfig github-releases
15+
16+
FILES:${PN} += "${datadir}"
17+
RDEPENDS:${PN} += "ghostscript"
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
DESCRIPTION = "OpenPrinting libppd"
2+
HOMEPAGE = "https://github.com/OpenPrinting"
3+
LICENSE = "Apache-2.0"
4+
LIC_FILES_CHKSUM = "file://COPYING;md5=c1fca671047153ce6825c4ab06f2ab49"
5+
6+
DEPENDS = "libcupsfilters"
7+
8+
SRC_URI = "https://github.com/OpenPrinting/${BPN}/releases/download/${PV}/${BP}.tar.xz"
9+
SRC_URI[sha256sum] = "882d3c659a336e91559de8f3c76fc26197fe6e5539d9b484a596e29a5a4e0bc8"
10+
11+
inherit autotools gettext pkgconfig github-releases
12+
13+
do_install:append() {
14+
rm -r ${D}${bindir}
15+
}
16+
17+
FILES:${PN} += "${datadir}"
18+

0 commit comments

Comments
 (0)