Perform this commit() action after onSaveInstanceState! #854

ywp0919 · 2018-05-02T07:15:50Z

Issues Guideline

Following information can help us to resolve the issue faster.

Library version 1.3.3
Support-v4 version 27.1.1
Logs
Screenshots

In addition, we do not accept issues unrelated to Fragmentation.

me.yokeyword.fragmentation.exception.AfterSaveStateTransactionWarning: Warning: Perform this commit() action after onSaveInstanceState!
at me.yokeyword.fragmentation.TransactionDelegate.handleAfterSaveInStateTransactionException(TransactionDelegate.java:713)
at me.yokeyword.fragmentation.TransactionDelegate.supportCommit(TransactionDelegate.java:493)
at me.yokeyword.fragmentation.TransactionDelegate.start(TransactionDelegate.java:455)
at me.yokeyword.fragmentation.TransactionDelegate.doDispatchStartTransaction(TransactionDelegate.java:385)
at me.yokeyword.fragmentation.TransactionDelegate.access$400(TransactionDelegate.java:32)
at me.yokeyword.fragmentation.TransactionDelegate$4.run(TransactionDelegate.java:132)
at me.yokeyword.fragmentation.queue.ActionQueue.handleAction(ActionQueue.java:53)
at me.yokeyword.fragmentation.queue.ActionQueue.enqueueAction(ActionQueue.java:45)
at me.yokeyword.fragmentation.queue.ActionQueue.access$000(ActionQueue.java:17)
at me.yokeyword.fragmentation.queue.ActionQueue$1.run(ActionQueue.java:37)
at android.os.Handler.handleCallback(Handler.java:751)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:177)
at com.trainor.hsehome.base.CatchCrash$setCrashHandler$1.run(CatchCrash.kt:24)
at android.os.Handler.handleCallback(Handler.java:751)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:177)
at android.app.ActivityThread.main(ActivityThread.java:6651)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:912)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:802)

很奇怪，我看到wiki的1.3.x版本的说明上说不会再出现after onSaveInstanceState! 但是后台的日志管理又看到了几条这样的log信息

YoKeyword · 2018-05-17T06:27:10Z

该异常是Fragmentation打印的，并不会导致崩溃，只是提示下在StateSaved状态下执行了事务，如果这个事务非常非常重要，需要无论如何都要保存正确性，需要你在此处再进行保存恢复处理

不会再出现after onSaveInstanceState

这个是因为库默认绕过了SaveState的检查，但是绕过时会通过下面的方式回调，并打印日志:

 Fragmentation.builder()
               ...
                .debug(true) // 实际场景建议.debug(BuildConfig.DEBUG)
                /**
                 * 可以获取到{@link me.yokeyword.fragmentation.exception.AfterSaveStateTransactionWarning}
                 * 在遇到After onSaveInstanceState时，不会抛出异常，会回调到下面的ExceptionHandler
                 */
                .handleException(new ExceptionHandler() {
                    @Override
                    public void onException(Exception e) {
                        // 以Bugtags为例子: 把捕获到的 Exception 传到 Bugtags 后台。
                        // Bugtags.sendException(e);
                    }
                })...

ywp0919 · 2018-05-17T06:31:18Z

ok，thanks

ywp0919 · 2018-05-17T06:34:08Z

那么我是否可以理解类似于以下Log信息的抛出是不会导致APP崩溃的么？
me.yokeyword.fragmentation.exception.AfterSaveStateTransactionWarning: Warning: Perform this commit() action after onSaveInstanceState!
at me.yokeyword.fragmentation.TransactionDelegate.handleAfterSaveInStateTransactionException(TransactionDelegate.java:713)
at me.yokeyword.fragmentation.TransactionDelegate.supportCommit(TransactionDelegate.java:493)
at me.yokeyword.fragmentation.TransactionDelegate.start(TransactionDelegate.java:455)
at me.yokeyword.fragmentation.TransactionDelegate.doDispatchStartTransaction(TransactionDelegate.java:385)
at me.yokeyword.fragmentation.TransactionDelegate.access$400(TransactionDelegate.java:32)
at me.yokeyword.fragmentation.TransactionDelegate$4.run(TransactionDelegate.java:132)
at me.yokeyword.fragmentation.queue.ActionQueue.handleAction(ActionQueue.java:53)
at me.yokeyword.fragmentation.queue.ActionQueue.enqueueAction(ActionQueue.java:45)
at me.yokeyword.fragmentation.queue.ActionQueue.access$000(ActionQueue.java:17)
at me.yokeyword.fragmentation.queue.ActionQueue$1.run(ActionQueue.java:37)
at android.os.Handler.handleCallback(Handler.java:751)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:177)
at com.trainor.hsehome.base.CatchCrash$setCrashHandler$1.run(CatchCrash.kt:24)
at android.os.Handler.handleCallback(Handler.java:751)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:177)
at android.app.ActivityThread.main(ActivityThread.java:6651)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:912)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:802)

java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState
at android.support.v4.app.FragmentManagerImpl.checkStateLoss(FragmentManager.java:2053)
at android.support.v4.app.FragmentManagerImpl.enqueueAction(FragmentManager.java:2079)
at android.support.v4.app.FragmentManagerImpl.popBackStack(FragmentManager.java:791)
at android.support.v4.app.FragmentationMagician$1.run(FragmentationMagician.java:87)
at android.support.v4.app.FragmentationMagician.hookStateSaved(FragmentationMagician.java:183)
at android.support.v4.app.FragmentationMagician.popBackStackAllowingStateLoss(FragmentationMagician.java:84)
at me.yokeyword.fragmentation.TransactionDelegate$9.run(TransactionDelegate.java:251)
at me.yokeyword.fragmentation.queue.ActionQueue.handleAction(ActionQueue.java:53)
at me.yokeyword.fragmentation.queue.ActionQueue.enqueueAction(ActionQueue.java:45)
at me.yokeyword.fragmentation.queue.ActionQueue.access$000(ActionQueue.java:17)
at me.yokeyword.fragmentation.queue.ActionQueue$1.run(ActionQueue.java:37)
at android.os.Handler.handleCallback(Handler.java:751)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:177)
at com.trainor.hsehome.base.CatchCrash$setCrashHandler$1.run(CatchCrash.kt:24)
at android.os.Handler.handleCallback(Handler.java:751)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:177)
at android.app.ActivityThread.main(ActivityThread.java:6651)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:912)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:802)

ywp0919 · 2018-05-17T06:35:09Z

java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState
at android.support.v4.app.FragmentManagerImpl.checkStateLoss(FragmentManager.java:2053)
at android.support.v4.app.FragmentManagerImpl.enqueueAction(FragmentManager.java:2079)
at android.support.v4.app.FragmentManagerImpl.popBackStack(FragmentManager.java:791)
at android.support.v4.app.FragmentationMagician$1.run(FragmentationMagician.java:87)
at android.support.v4.app.FragmentationMagician.hookStateSaved(FragmentationMagician.java:183)
at android.support.v4.app.FragmentationMagician.popBackStackAllowingStateLoss(FragmentationMagician.java:84)
at me.yokeyword.fragmentation.TransactionDelegate$9.run(TransactionDelegate.java:251)
at me.yokeyword.fragmentation.queue.ActionQueue.handleAction(ActionQueue.java:53)
at me.yokeyword.fragmentation.queue.ActionQueue.enqueueAction(ActionQueue.java:45)
at me.yokeyword.fragmentation.queue.ActionQueue.access$000(ActionQueue.java:17)
at me.yokeyword.fragmentation.queue.ActionQueue$1.run(ActionQueue.java:37)
at android.os.Handler.handleCallback(Handler.java:751)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:177)
at com.trainor.hsehome.base.CatchCrash$setCrashHandler$1.run(CatchCrash.kt:24)
at android.os.Handler.handleCallback(Handler.java:751)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:177)
at android.app.ActivityThread.main(ActivityThread.java:6651)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:912)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:802)

YoKeyword · 2018-05-17T06:40:48Z

me.yokeyword.fragmentation.exception.AfterSaveStateTransactionWarning: Warning: Perform this commit() action after onSaveInstanceState!

这个只是打印了Log

java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState

这个是崩溃， #863 不知道你是否也是用了v27.1.1的v4包？稍后调研下如果没有副作用的话会考虑兼容

ywp0919 · 2018-05-17T06:42:32Z

是的，我用的是v27.1.1的v4包，那么请问目前应该使用哪个版本的v4包呢?

ywp0919 · 2018-05-17T06:44:40Z

ok我先退回27.1.0这个版本

YoKeyword · 2018-05-17T09:22:34Z

v1.3.4兼容了该问题

YoKeyword closed this as completed May 17, 2018

YoKeyword added the after onSaveInstanceState label Jun 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Perform this commit() action after onSaveInstanceState! #854

Perform this commit() action after onSaveInstanceState! #854

ywp0919 commented May 2, 2018

YoKeyword commented May 17, 2018

Uh oh!

ywp0919 commented May 17, 2018

Uh oh!

ywp0919 commented May 17, 2018

Uh oh!

ywp0919 commented May 17, 2018

Uh oh!

YoKeyword commented May 17, 2018

Uh oh!

ywp0919 commented May 17, 2018

Uh oh!

ywp0919 commented May 17, 2018

Uh oh!

YoKeyword commented May 17, 2018

Uh oh!

Perform this commit() action after onSaveInstanceState! #854

Perform this commit() action after onSaveInstanceState! #854

Comments

ywp0919 commented May 2, 2018

Issues Guideline

YoKeyword commented May 17, 2018

Uh oh!

ywp0919 commented May 17, 2018

Uh oh!

ywp0919 commented May 17, 2018

Uh oh!

ywp0919 commented May 17, 2018

Uh oh!

YoKeyword commented May 17, 2018

Uh oh!

ywp0919 commented May 17, 2018

Uh oh!

ywp0919 commented May 17, 2018

Uh oh!

YoKeyword commented May 17, 2018

Uh oh!