Optimized FragmentationMagician.java

Author: YoKeyword

fragmentation_core/src/main/java/android/support/v4/app/FragmentationMagician.java

@@ -14,8 +14,8 @@
  * Created by YoKey on 16/1/22.
  */
 public class FragmentationMagician {
-    public static boolean sSupportLessThan25dot4 = false;
-    public static boolean sSupportGreaterThan27dot1dot0 = false;
+    private static boolean sSupportLessThan25dot4 = false;
+    private static boolean sSupportGreaterThan27dot1dot0 = false;
 
     static {
         Field[] fields = FragmentManagerImpl.class.getDeclaredFields();
@@ -30,6 +30,10 @@ public class FragmentationMagician {
         }
     }
 
+    public static boolean isSupportLessThan25dot4() {
+        return sSupportLessThan25dot4;
+    }
+
     public static boolean isExecutingActions(FragmentManager fragmentManager) {
         if (!(fragmentManager instanceof FragmentManagerImpl))
             return false;
@@ -193,18 +197,19 @@ private static void hookStateSaved(FragmentManager fragmentManager, Runnable run
 
     /**
      * Compat v27.1.0+
-     *
+     * <p>
      * So the code to compile Fragmentation needs v27.1.0+
      *
      * @see FragmentManager#isStateSaved()
      */
     private static void compatRunAction(FragmentManagerImpl fragmentManagerImpl, Runnable runnable) {
-        if (sSupportGreaterThan27dot1dot0) {
-            fragmentManagerImpl.mStopped = false;
-            runnable.run();
-            fragmentManagerImpl.mStopped = true;
-        } else {
+        if (!sSupportGreaterThan27dot1dot0) {
             runnable.run();
+            return;
         }
+
+        fragmentManagerImpl.mStopped = false;
+        runnable.run();
+        fragmentManagerImpl.mStopped = true;
     }
 }

fragmentation_core/src/main/java/me/yokeyword/fragmentation/TransactionDelegate.java

@@ -575,7 +575,7 @@ private void safePopTo(String fragmentTag, final FragmentManager fm, int flag, L
         FragmentationMagician.executePendingTransactionsAllowingStateLoss(fm);
         mSupport.getSupportDelegate().mPopMultipleNoAnim = false;
 
-        if (FragmentationMagician.sSupportLessThan25dot4) {
+        if (FragmentationMagician.isSupportLessThan25dot4()) {
             mHandler.post(new Runnable() {
                 @Override
                 public void run() {