Skip to content

Commit d02ed19

Browse files
committed
Released 1.23.2 via make release
1 parent 1ac456b commit d02ed19

File tree

5 files changed

+38
-2
lines changed

5 files changed

+38
-2
lines changed

debian/changelog

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,31 @@
1+
paasta-tools (1.23.2) xenial; urgency=medium
2+
3+
* 1.23.2 tagged with 'make release'
4+
Commit: Add better error handling for 403s in remote-run (#4074) ##
5+
Problems ### Swagger spec The swagger spec specified that for 403s
6+
in remote_run, there should be no data in the response. However,
7+
there are error messages that should be returned. Because of this,
8+
they got wrapped in another error: ``` The server has either erred
9+
or is incapable of performing the requested operation. Response
10+
body should be empty: {"reason": "User not owning service"} ``` ###
11+
Client error handling The remote run code expects non-200s to be
12+
available in the client response objects, however, the current code
13+
will automatically raise ApiExceptions. So rather than "Error from
14+
PaaSTA APIs while...", you"d get a full client side traceback. ##
15+
Solutions ### Swagger spec Add `reason` as a response type in
16+
swagger.json. I"m not sure if this needs to be reflected in
17+
oapi.yaml as well, as that doesn"t seem to have any effect. I"ve
18+
also left every other API unchanged, even though some could generate
19+
500s or 403s. These are the two that are most important. ###
20+
Client error handling Catch ApiExceptions and try parsing error body
21+
as best as possible. ## Validation ``` paasta remote-run start -c
22+
cluster -s service -i main --interactive Error from PaaSTA APIs
23+
while starting job: User not owning service $ paasta remote-run
24+
stop -c cluster -s service -i main Error from PaaSTA APIs while
25+
stopping job: User not owning service ```
26+
27+
-- Luis Perez <[email protected]> Fri, 06 Jun 2025 09:40:30 -0700
28+
129
paasta-tools (1.23.1) xenial; urgency=medium
230

331
* 1.23.1 tagged with 'make release'
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
paasta\_tools.paastaapi.model.inline\_response403 module
2+
========================================================
3+
4+
.. automodule:: paasta_tools.paastaapi.model.inline_response403
5+
:members:
6+
:undoc-members:
7+
:show-inheritance:

docs/source/generated/paasta_tools.paastaapi.model.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ Submodules
2525
paasta_tools.paastaapi.model.inline_response200
2626
paasta_tools.paastaapi.model.inline_response2001
2727
paasta_tools.paastaapi.model.inline_response202
28+
paasta_tools.paastaapi.model.inline_response403
2829
paasta_tools.paastaapi.model.instance_bounce_status
2930
paasta_tools.paastaapi.model.instance_mesh_status
3031
paasta_tools.paastaapi.model.instance_status

paasta_tools/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@
1717
# setup phase, the dependencies may not exist on disk yet.
1818
#
1919
# Don't bump version manually. See `make release` docs in ./Makefile
20-
__version__ = "1.23.1"
20+
__version__ = "1.23.2"

yelp_package/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
# limitations under the License.
1414

1515
# Edit this release and run "make release"
16-
RELEASE=1.23.1
16+
RELEASE=1.23.2
1717

1818
SHELL=/bin/bash
1919

0 commit comments

Comments
 (0)