Skip to content

Express 4 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NoumanSaleem opened this issue Apr 21, 2014 · 7 comments
Closed

Express 4 #28

NoumanSaleem opened this issue Apr 21, 2014 · 7 comments

Comments

@NoumanSaleem
Copy link
Contributor

Express 4 is now released; however express-state declares a hard dependency on express 3.x: https://github.com/yahoo/express-state/blob/master/package.json#L41

I do not see anything breaking in the code. Here's a list of changes: https://github.com/visionmedia/express/wiki/Migrating-from-3.x-to-4.x

Would be great to get new version out with express 4.x support.

thanks!

@ericf
Copy link
Collaborator

ericf commented Apr 21, 2014

Yeah, this is planned. It would be great if you were able to give Express v4.x a try with Express State to make sure it works and report back here.

@NoumanSaleem
Copy link
Contributor Author

I am not seeing any issues.
namespace/app.expose/response.expose all works the same.

@NoumanSaleem
Copy link
Contributor Author

@ericf Any time frame on this? Sorry to nag. Looking to get Express 4 into production

@ericf
Copy link
Collaborator

ericf commented Apr 24, 2014

@NoumanSaleem you said that it worked in your Express v4 app. So if you want to update the test you found that fails and the peer dependency in the package.json and issue a Pull Request, then I'll merge and release an update.

@NoumanSaleem
Copy link
Contributor Author

@ericf no problem, will submit a PR soon

@NoumanSaleem
Copy link
Contributor Author

#29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants