not compare strings in func CompareSignersLists

gzliudan · gzliudan · commit e41b8db02630 · 2023-10-23T16:18:52.000+08:00
diff --git a/consensus/XDPoS/utils/utils.go b/consensus/XDPoS/utils/utils.go
@@ -68,10 +68,10 @@ func CompareSignersLists(list1 []common.Address, list2 []common.Address) bool {
 	}
 
 	sort.Slice(l1, func(i, j int) bool {
-		return l1[i].String() <= l1[j].String()
+		return bytes.Compare(l1[i][:], l1[j][:]) == -1
 	})
 	sort.Slice(l2, func(i, j int) bool {
-		return l2[i].String() <= l2[j].String()
+		return bytes.Compare(l2[i][:], l2[j][:]) == -1
 	})
 	return reflect.DeepEqual(l1, l2)
 }

Original file line number	Diff line number	Diff line change
`@@ -68,10 +68,10 @@ func CompareSignersLists(list1 []common.Address, list2 []common.Address) bool {`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`sort.Slice(l1, func(i, j int) bool {`
`71`		`- return l1[i].String() <= l1[j].String()`
	`71`	`+ return bytes.Compare(l1[i][:], l1[j][:]) == -1`
`72`	`72`	`})`
`73`	`73`	`sort.Slice(l2, func(i, j int) bool {`
`74`		`- return l2[i].String() <= l2[j].String()`
	`74`	`+ return bytes.Compare(l2[i][:], l2[j][:]) == -1`
`75`	`75`	`})`
`76`	`76`	`return reflect.DeepEqual(l1, l2)`
`77`	`77`	`}`