Settings (ladybird:a39b1f334aa85b6faefd8fafbf987d613262df98, ladybird:4a445cf084907e0d8535aff2ae258de3cc9ad0f0, ladybird:c9722377f1650d38f81c445d3a5434cdec1e09b6)

Author: Xexxa

BrowserWindow.cpp

@@ -6,13 +6,17 @@
  */
 
 #include "BrowserWindow.h"
+#include "Settings.h"
+#include "SettingsDialog.h"
 #include "WebView.h"
 #include <LibCore/EventLoop.h>
 #include <QAction>
+#include <QDialog>
 #include <QPlainTextEdit>
 #include <QMessageBox>
 
 extern String s_serenity_resource_root;
+extern Browser::Settings* s_settings;
 
 BrowserWindow::BrowserWindow(Core::EventLoop& event_loop)
     : m_event_loop(event_loop)
@@ -100,7 +104,6 @@ BrowserWindow::BrowserWindow(Core::EventLoop& event_loop)
     auto* preferences_action = new QAction("Prefe&rences");
     preferences_action->setIcon(QIcon(QString("%1/res/icons/16x16/settings.png").arg(s_serenity_resource_root.characters())));
     preferences_action->setShortcut(QKeySequence(QKeySequence::Preferences)); // "Ctrl+, (macOS)"
-    preferences_action->setEnabled(false);
     edit_menu->addAction(preferences_action);
 
     auto* view_menu = menuBar()->addMenu("&View");
@@ -263,6 +266,9 @@ BrowserWindow::BrowserWindow(Core::EventLoop& event_loop)
     about_action->setIcon(QIcon(QString("../icons/16x16/app-coccinellidae.png")));
     help_menu->addAction(about_action);
 
+    QObject::connect(preferences_action, &QAction::triggered, this, [this] {
+        new SettingsDialog(this);
+    });
     QObject::connect(about_action, &QAction::triggered, this, &BrowserWindow::about);
 
     QObject::connect(new_tab_action, &QAction::triggered, this, &BrowserWindow::new_tab);

CMakeLists.qt6.txt

@@ -43,6 +43,8 @@ set(SOURCES
     main.cpp
     WebView.cpp
     History.cpp
+    Settings.cpp
+    SettingsDialog.cpp
     Tab.cpp
 )
 

CMakeLists.txt

@@ -45,6 +45,8 @@ set(SOURCES
     main.cpp
     WebView.cpp
     History.cpp
+    Settings.cpp
+    SettingsDialog.cpp
     Tab.cpp
 )
 

Settings.cpp

@@ -0,0 +1,26 @@
+/*
+ * Copyright (c) 2022, Filiph Sandström <[email protected]>
+ *
+ * SPDX-License-Identifier: BSD-2-Clause
+ */
+
+#include "Settings.h"
+
+namespace Browser {
+
+Settings::Settings()
+{
+    m_qsettings = new QSettings("Serenity", "Ladybird");
+}
+
+QString Settings::homepage()
+{
+    return m_qsettings->value("homepage", "https://home.coccinellidae.serenityos.net").toString();
+}
+
+void Settings::set_homepage(QString const& homepage)
+{
+    m_qsettings->setValue("homepage", homepage);
+}
+
+}

Settings.h

@@ -0,0 +1,27 @@
+/*
+ * Copyright (c) 2022, Filiph Sandström <[email protected]>
+ *
+ * SPDX-License-Identifier: BSD-2-Clause
+ */
+
+#pragma once
+
+#define AK_DONT_REPLACE_STD
+
+#include <AK/String.h>
+#include <QSettings>
+
+namespace Browser {
+
+class Settings {
+public:
+    Settings();
+
+    QString homepage();
+    void set_homepage(QString const& homepage);
+
+private:
+    QSettings* m_qsettings;
+};
+
+}

SettingsDialog.cpp

@@ -0,0 +1,48 @@
+/*
+ * Copyright (c) 2022, Filiph Sandström <[email protected]>
+ *
+ * SPDX-License-Identifier: BSD-2-Clause
+ */
+
+#include "Settings.h"
+#include "SettingsDialog.h"
+#include <QCloseEvent>
+#include <QLabel>
+
+extern Browser::Settings* s_settings;
+
+SettingsDialog::SettingsDialog(QMainWindow* window)
+    : m_window(window)
+{
+    m_layout = new QFormLayout;
+    m_homepage = new QLineEdit;
+    m_ok_button = new QPushButton("&Save");
+
+    m_layout->addWidget(new QLabel("Homepage"));
+    m_layout->addWidget(m_homepage);
+    m_layout->addWidget(m_ok_button);
+
+    m_homepage->setText(s_settings->homepage());
+
+    QObject::connect(m_ok_button, &QPushButton::released, this, [this] {
+        close();
+    });
+    
+    setWindowTitle("Settings");
+    setFixedWidth(300);
+    setLayout(m_layout);
+    show();
+    setFocus();
+}
+
+void SettingsDialog::closeEvent(QCloseEvent *event)
+{
+    save();
+    event->accept();
+}
+
+void SettingsDialog::save()
+{
+    // FIXME: Validate data.
+    s_settings->set_homepage(m_homepage->text());
+}

SettingsDialog.h

@@ -0,0 +1,29 @@
+/*
+ * Copyright (c) 2022, Filiph Sandström <[email protected]>
+ *
+ * SPDX-License-Identifier: BSD-2-Clause
+ */
+
+#include <QFormLayout>
+#include <QDialog>
+#include <QMainWindow>
+#include <QLineEdit>
+#include <QPushButton>
+
+#pragma once
+
+class SettingsDialog : public QDialog {
+    Q_OBJECT
+public:
+    explicit SettingsDialog(QMainWindow* window);
+    
+    void save();
+
+    virtual void closeEvent(QCloseEvent*) override;
+
+private:
+    QFormLayout* m_layout;
+    QPushButton* m_ok_button { nullptr };
+    QLineEdit* m_homepage { nullptr };
+    QMainWindow* m_window { nullptr };
+};

Tab.cpp

@@ -7,12 +7,14 @@
 
 #include "Tab.h"
 #include "BrowserWindow.h"
+#include "Settings.h"
 #include "History.h"
 #include <QCoreApplication>
 #include <QStatusBar>
 #include <QLabel>
 
 extern String s_serenity_resource_root;
+extern Browser::Settings* s_settings;
 
 Tab::Tab(QMainWindow* window)
     : m_window(window)
@@ -151,7 +153,8 @@ void Tab::forward()
 
 void Tab::home()
 {
-    navigate("https://home.coccinellidae.serenityos.net");
+    //navigate("https://home.coccinellidae.serenityos.net");
+    navigate(s_settings->homepage());
 }
 
 void Tab::reload()

main.cpp

@@ -5,6 +5,7 @@
  */
 
 #include "BrowserWindow.h"
+#include "Settings.h"
 #include "WebView.h"
 #include <LibCore/ArgsParser.h>
 #include <LibCore/EventLoop.h>
@@ -14,6 +15,7 @@
 #include <QWidget>
 
 extern void initialize_web_engine();
+Browser::Settings* s_settings;
 
 ErrorOr<int> serenity_main(Main::Arguments arguments)
 {
@@ -25,6 +27,8 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
     args_parser.add_positional_argument(url, "URL to open", "url", Core::ArgsParser::Required::No);
     args_parser.parse(arguments);
 
+    s_settings = new Browser::Settings();
+
     Core::EventLoop event_loop;
 
     QApplication app(arguments.argc, arguments.argv);