Skip to content

Commit 14f7126

Browse files
authored
Merge pull request #206 from WyriHaximus/WyriHaximus-patch-1
Fix typos
2 parents 6762794 + b330e84 commit 14f7126

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

source/_posts/2025-03-31-announcing-testinfra-action.markdown

+3-3
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ social:
1919
---
2020

2121
One of the key parts of [`Building Secure Images with GitHub Actions`](https://blog.wyrihaximus.net/2024/10/building-secure-images-with-github-actions/)
22-
is unit testing the image just build. While for most of my repositories this has been some bash script in the repo that
22+
is unit testing the image just built. While for most of my repositories this has been some bash script in the repo that
2323
I copied to the next new repo. Always had the desire to make something more clean than that, this action is the outcome
2424
of that desire.
2525

@@ -47,14 +47,14 @@ Another major requirement is that it should be easy to use. This resulted in som
4747
# Challenges
4848

4949
The biggest issue I had while creating this action was to keep the container running. Not because it was hard to do,
50-
but because I head to realise it depends on each image if it keeps running after started or not. The
50+
but because I had to realise it depends on each image if it keeps running after being started or not. The
5151
[original](https://github.com/usabilla/php-docker-template/blob/1e379cfdb90f9b03b4e4e4c6b7212134091040ce/test-cli.sh#L24)
5252
I took this from, [copied](https://github.com/WyriHaximusNet/docker-php/blob/345e0fca8d7b2099fef71af2c244c7b70f800107/test-zts.sh#L42)
5353
over again and again, and then taking the script and putting it in this action; took care of that. This is why the
5454
action has a `cmd` for image that require that. Something that keeps running like `PHP` or `nodejs` REPL is good enough.
5555

5656
The coming challenge is going to be updating my [PHP Docker](https://github.com/WyriHaximusNet/docker-php) workflow.
57-
It’s build to test all different tags build in a single build run, this action isn’t very keep on that. It can only
57+
It’s built to test all different tags build in a single build run, this action isn’t very keep on that. It can only
5858
handle a single test suite for the images you pass it. So no looping or any of that, going to have to do a major
5959
overhaul of that workflow. But hopefully this refactor is one I can use in my other image building workflows until the
6060
point I can have one general one as a reusable workflow.

0 commit comments

Comments
 (0)