Skip to content

Commit a95d08d

Browse files
committed
GH Actions: always quote variables
... to satisfy shellcheck rule SC2086: "Double quote to prevent globbing and word splitting". Ref: https://www.shellcheck.net/wiki/SC2086
1 parent 2133137 commit a95d08d

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/basic-qa.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ jobs:
186186
set +e
187187
$(pwd)/vendor/bin/phpcbf -pq ./WordPress/Tests/ --standard=WordPress --extensions=inc --exclude=Generic.PHP.Syntax --report=summary --ignore=/WordPress/Tests/WP/GlobalVariablesOverrideUnitTest.7.inc
188188
exitcode="$?"
189-
echo "EXITCODE=$exitcode" >> $GITHUB_OUTPUT
189+
echo "EXITCODE=$exitcode" >> "$GITHUB_OUTPUT"
190190
exit "$exitcode"
191191
192192
- name: Fail the build on fixer conflicts and other errors

.github/workflows/unit-tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,9 @@ jobs:
9191
id: set_ini
9292
run: |
9393
if [ "${{ matrix.dependencies }}" != "dev" ]; then
94-
echo 'PHP_INI=error_reporting=E_ALL & ~E_DEPRECATED, display_errors=On' >> $GITHUB_OUTPUT
94+
echo 'PHP_INI=error_reporting=E_ALL & ~E_DEPRECATED, display_errors=On' >> "$GITHUB_OUTPUT"
9595
else
96-
echo 'PHP_INI=error_reporting=-1, display_errors=On' >> $GITHUB_OUTPUT
96+
echo 'PHP_INI=error_reporting=-1, display_errors=On' >> "$GITHUB_OUTPUT"
9797
fi
9898
9999
- name: Set up PHP

0 commit comments

Comments
 (0)