Disable the polyfill when the method is available in ember-source #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since it wasn't part of 3.28 the earliest this can be included is in the 4.1 release. |
Ember 4.1 includes the refresh method so the polyfill can be safely disabled.
Windvis
force-pushed
the
disable-polyfill-with-embroider-macros
branch
from
e65e1d0 to
df796af
Compare
Windvis
changed the title
Windvis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses @embroider/macros to disable the polyfill when the addon runs in an Ember version that includes the refresh method already.
Draft status since the exact version isn't known yet, and it might be "better" to use the treeFor hooks and not return the initializer files at all. That's how other ember polyfills seem to do it.It's released in Ember 4.1.0-beta.1 🎉.Closes #1