Skip to content

Users can access Dormtrak/Factrak reviews by changing URL #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
enismaxim1 opened this issue Apr 19, 2022 · 1 comment
Open

Users can access Dormtrak/Factrak reviews by changing URL #205

enismaxim1 opened this issue Apr 19, 2022 · 1 comment

Comments

@enismaxim1
Copy link
Contributor

If a user navigates to some page such as https://wso.williams.edu/factrak/surveys/edit?surveyID=23973, they can access this review's edit form. Upon trying to edit, the backend checks that the current user is the review creator, so there is no security issue. However, the user should be unable to access the form to begin with.

@yechs
Copy link
Member

yechs commented Apr 23, 2022

For UI/UX, what about disabling all input fields and showing a message "You do not have access to edit this review" instead? Redirecting user to error page seems a little strange (plus our error page does not support going back now)

For implementation, we can probably add a boolean field editable to the API return value. So the frontend knows if the review is editable or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants