Skip to content

JOSS review: error encountered in SmoothFilterSignals #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wbaccinelli opened this issue Mar 10, 2025 · 1 comment
Open

JOSS review: error encountered in SmoothFilterSignals #4

wbaccinelli opened this issue Mar 10, 2025 · 1 comment

Comments

@wbaccinelli
Copy link

When running the provided Simple Example with the dataset indicated in the paper, I get the following error when running

EMGFlow.SmoothFilterSignals(band_path, smooth_path, sampling_rate, smooth_window)
TypeError                                 Traceback (most recent call last)
Cell In[10], line 4
      2 EMGFlow.NotchFilterSignals(raw_path, notch_path, sampling_rate, notch_vals)
      3 EMGFlow.BandpassFilterSignals(notch_path, band_path, sampling_rate, band_low, band_high)
----> 4 EMGFlow.SmoothFilterSignals(band_path, smooth_path, sampling_rate, smooth_window)

File ~\anaconda3\envs\emgflow\lib\site-packages\EMGFlow\PreprocessSignals.py:836, in SmoothFilterSignals(in_path, out_path, window_size, cols, expression, exp_copy, file_ext, method, sigma)
    833         cols.remove('Time')
    835 # Apply filter to columns
--> 836 for col in cols:
    837     if method == 'rms':
    838         data = ApplyRMSSmooth(data, col, window_size)

TypeError: 'int' object is not iterable

Could you, please, address this?

@faroit
Copy link

faroit commented Mar 10, 2025

cross-referencing the review issue to keep track of the status openjournals/joss-reviews#7696

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants