Skip to content

JOSS Review: Please remove temporary artifacts and no-source binaries from the repository #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
samiralavi opened this issue Mar 2, 2025 · 2 comments
Closed

JOSS Review: Please remove temporary artifacts and no-source binaries from the repository #2

samiralavi opened this issue Mar 2, 2025 · 2 comments

Comments

@samiralavi
Copy link

The repository structure is good, however, there are some files that shouldn't have been added to the git source control. Generally, only source files should be version controlled. Here are some examples to remove:

  • EMGFlow-Package/dist
  • __pycache__
@samiralavi samiralavi mentioned this issue Mar 2, 2025
Open
@WiIIson
Copy link
Owner

WiIIson commented Mar 24, 2025

Thanks for catching that issue. We've updated the .gitignore and these files are no longer included in recent comments.

@faroit
Copy link

faroit commented Apr 29, 2025

ref openjournals/joss-reviews#7696

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@faroit @samiralavi @WiIIson