Skip to content

JOSS Review: Please add a working example file with sample raw data #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samiralavi opened this issue Mar 2, 2025 · 5 comments
Open

Comments

@samiralavi
Copy link

I couldn't find a working example due to missing sample data. All of the example codes in the documentation require /data with specific raw data, which basically stops readers from running the examples as those data are not provided even in samples. Could you please provide a simple dataset that can be used in the examples to make the example self-sufficient to run?

@faroit
Copy link

faroit commented Mar 10, 2025

cross-referencing the review issue to keep track of the status openjournals/joss-reviews#7696

@WiIIson
Copy link
Owner

WiIIson commented Mar 24, 2025

Hi @samiralavi, thanks for the suggestion. I have added sample data to the toolkit, and updated the examples pages which shows how to access and use these inbuilt data.

@samiralavi
Copy link
Author

@WiIIson thanks, I can see the new sample data. It is good, however, the link to is broken on the Readme.me file

@WiIIson
Copy link
Owner

WiIIson commented Apr 4, 2025

Hi @samiralavi, that was bad timing on my part, you probably checked in while I was working on it yesterday. They should be working now.

@faroit
Copy link

faroit commented Apr 29, 2025

@samiralavi @WiIIson can this be closed?

ref: openjournals/joss-reviews#7696

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants