handle binary operators in patterns

Summary:
- we did not handle such edge cases previously
- fixes T137398643

Reviewed By: VLanvin

Differential Revision: D41255663

fbshipit-source-id: 7725717323165a3d833ec31aa9d5818e1c33237a

Author: ilya-klyuchnikov

eqwalizer/src/main/scala/com/whatsapp/eqwalizer/tc/ElabPat.scala

@@ -191,6 +191,8 @@ final class ElabPat(pipelineContext: PipelineContext) {
           case _ => (NoneType, env2)
           // $COVERAGE-ON$
         }
+      case ">" | "<" | "/=" | ">=" | "=<" | "=/=" | "=:=" | "==" =>
+        (booleanType, env)
       // $COVERAGE-OFF$
       case _ => throw UnhandledOp(binOp.pos, op)
       // $COVERAGE-ON$

eqwalizer/test_projects/_cli/checkable_funs.cli

@@ -1,7 +1,7 @@
 all funs:
-                                               All : 2764
-                                         Checkable : 2503
-                              Well-typed checkable : 1610
+                                               All : 2765
+                                         Checkable : 2504
+                              Well-typed checkable : 1611
                                    Checkable ratio : 91%
                          Health ratio of checkable : 64%
                                        error count : 892
@@ -26,18 +26,18 @@ generated non-test funs:
 
 --------------------------------------------
 non-generated funs:
-                                               All : 2764
-                                         Checkable : 2503
-                              Well-typed checkable : 1610
+                                               All : 2765
+                                         Checkable : 2504
+                              Well-typed checkable : 1611
                                    Checkable ratio : 91%
                          Health ratio of checkable : 64%
                                        error count : 892
 
 --------------------------------------------
 non-generated non-test funs (most important):
-                                               All : 2762
-                                         Checkable : 2501
-                              Well-typed checkable : 1609
+                                               All : 2763
+                                         Checkable : 2502
+                              Well-typed checkable : 1610
                                    Checkable ratio : 91%
                          Health ratio of checkable : 64%
                                        error count : 891

eqwalizer/test_projects/_cli/discarded_specs.cli

@@ -49,5 +49,5 @@ type_aliases:uses_trans_unbound_var/2
 type_aliases:uses_ty_w_unbound_var/2
 type_aliases:uses_ty_w_unbound_var2/0
 Discarded specs: 49
-Total specs: 2640
-Discarded ratio: 1.8561 %
+Total specs: 2641
+Discarded ratio: 1.8554 %

eqwalizer/test_projects/_cli/misc.json

@@ -2559,7 +2559,8 @@
         "module": "gradual_misc",
         "exported_funs": [
           "use_invalid_opaque_1/1",
-          "use_invalid_opaque_2/1"
+          "use_invalid_opaque_2/1",
+          "f/1"
         ]
       },
       {

eqwalizer/test_projects/_cli/numbers.cli

@@ -1,6 +1,6 @@
 all specs:
-    containing number: 13.32%
-    containing integer: 10.51%
+    containing number: 13.31%
+    containing integer: 10.50%
     containing pos_integer: 3.34%
     containing non_neg_integer: 2.05%
     containing neg_integer: 1.52%
@@ -21,8 +21,8 @@ generated specs:
     containing range: 0.00%
     containing int lit: 0.00%
 non-generated specs:
-    containing number: 13.32%
-    containing integer: 10.51%
+    containing number: 13.31%
+    containing integer: 10.50%
     containing pos_integer: 3.34%
     containing non_neg_integer: 2.05%
     containing neg_integer: 1.52%

eqwalizer/test_projects/check_gradual/src/gradual_misc.erl

@@ -20,3 +20,7 @@ use_invalid_opaque_1(X) ->
 ) -> opaque:contravariant(a).
 use_invalid_opaque_2(X) ->
   X.
+
+-spec f(map()) -> ok.
+f(#{(#{} =/= a) := _}) ->
+  ok.

eqwalizer/test_projects/check_gradual/src/gradual_misc.erl.check

@@ -22,3 +22,7 @@ use_invalid_opaque_1(X) ->                 |         |
 ) -> opaque:contravariant(a).              |         |
 use_invalid_opaque_2(X) ->                 |         |
   X.                                       |         |
+                                           |         |
+-spec f(map()) -> ok.                      |         |
+f(#{(#{} =/= a) := _}) ->                  | OK      |
+  ok.                                      |         |