Skip to content

iOS selecting dates with markers + label #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jose-seabra opened this issue Jun 12, 2024 · 2 comments
Closed

iOS selecting dates with markers + label #904

jose-seabra opened this issue Jun 12, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@jose-seabra
Copy link

Describe the bug
On iOS, selecting dates with markers + label toggles the tooltip without selecting the date. The behavior on android is to toggle the tooltip and selects the date.

To Reproduce
Steps to reproduce the behavior:

  1. Use an iOS device or emulator
  2. Go to this demo https://stackblitz.com/edit/vitejs-vite-qtgtb9 or serve it's example code to your device/emulator
  3. Click on a date with a marker
  4. See how the first click only opens the tooltip and a second click is required in order to select the date

Expected behavior
I would expect iOS to have the same behavior as android, because as it is right now you need to click twice on a date in order to select it.

Screenshots
Clicking once:
image

Clicking twice:
image

Desktop & mobile (please complete the following information):

  • iPhone 13 v16.3, Safari
  • Library version 8.8.0

I've played around with possible solutions and if we change the @click event for a @touchend event it behaves just as my expectation.
<div v-if="dayVal.marker?.tooltip" class="dp__tooltip_content" @click="onTpClick">
<div v-if="dayVal.marker?.tooltip" class="dp__tooltip_content" @touchend="onTpClick">
src/VueDatePicker/components/DatePicker/DpCalendar.vue:94

I'm not knowledgeable enough to understand if such change would break other expected behaviors, but it appears to make it work the same on iOS/android/desktop

@jose-seabra jose-seabra added awaiting triage The issue is not reviewed by the maintainers bug Something isn't working labels Jun 12, 2024
@jose-seabra
Copy link
Author

Should this be handled with the allowPreventDefault config? It makes it so it doesn't require two clicks to select the date but the tooltip won't trigger

@Jasenkoo Jasenkoo removed the awaiting triage The issue is not reviewed by the maintainers label Jun 20, 2024
@perruche
Copy link

perruche commented Jul 3, 2024

Having the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants