Skip to content

Commit 2653732

Browse files
authored
respect msvc grammar for YR_DEPRECATED (#1911)
1 parent c0c10b7 commit 2653732

File tree

2 files changed

+24
-24
lines changed

2 files changed

+24
-24
lines changed

libyara/include/yara/types.h

+3-3
Original file line numberDiff line numberDiff line change
@@ -563,7 +563,7 @@ struct YR_RULES
563563
// deprecated, which will raise a warning if used.
564564
// TODO(vmalvarez): Remove this field when a reasonable a few versions
565565
// after 4.1 has been released.
566-
YR_RULE* rules_list_head YR_DEPRECATED;
566+
YR_DEPRECATED(YR_RULE* rules_list_head);
567567
};
568568

569569
// Array of pointers with an entry for each of the defined strings. The idx
@@ -576,7 +576,7 @@ struct YR_RULES
576576
// deprecated, which will raise a warning if used.
577577
// TODO(vmalvarez): Remove this field when a reasonable a few versions
578578
// after 4.1 has been released.
579-
YR_STRING* strings_list_head YR_DEPRECATED;
579+
YR_DEPRECATED(YR_STRING* strings_list_head);
580580
};
581581

582582
// Array of pointers with an entry for each external variable.
@@ -588,7 +588,7 @@ struct YR_RULES
588588
// as deprecated, which will raise a warning if used.
589589
// TODO(vmalvarez): Remove this field when a reasonable a few versions
590590
// after 4.1 has been released.
591-
YR_EXTERNAL_VARIABLE* externals_list_head YR_DEPRECATED;
591+
YR_DEPRECATED(YR_EXTERNAL_VARIABLE* externals_list_head);
592592
};
593593

594594
// Pointer to the Aho-Corasick transition table.

libyara/include/yara/utils.h

+21-21
Original file line numberDiff line numberDiff line change
@@ -55,38 +55,38 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
5555
#if defined(_WIN32) || defined(__CYGWIN__)
5656
#ifdef YR_BUILDING_DLL
5757
#ifdef __GNUC__
58-
#define YR_API EXTERNC __attribute__((dllexport))
59-
#define YR_DEPRECATED_API EXTERNC __attribute__((deprecated))
60-
#define YR_DEPRECATED __attribute__((deprecated))
58+
#define YR_API EXTERNC __attribute__((dllexport))
59+
#define YR_DEPRECATED_API EXTERNC __attribute__((deprecated))
60+
#define YR_DEPRECATED(statement) statement __attribute__((deprecated))
6161
#else
62-
#define YR_API EXTERNC __declspec(dllexport)
63-
#define YR_DEPRECATED_API EXTERNC __declspec(deprecated)
64-
#define YR_DEPRECATED __declspec(deprecated)
62+
#define YR_API EXTERNC __declspec(dllexport)
63+
#define YR_DEPRECATED_API EXTERNC __declspec(deprecated)
64+
#define YR_DEPRECATED(statement) __declspec(deprecated) statement
6565
#endif
6666
#elif defined(YR_IMPORTING_DLL)
6767
#ifdef __GNUC__
68-
#define YR_API EXTERNC __attribute__((dllimport))
69-
#define YR_DEPRECATED_API EXTERNC __attribute__((deprecated))
70-
#define YR_DEPRECATED __attribute__((deprecated))
68+
#define YR_API EXTERNC __attribute__((dllimport))
69+
#define YR_DEPRECATED_API EXTERNC __attribute__((deprecated))
70+
#define YR_DEPRECATED(statement) statement __attribute__((deprecated))
7171
#else
72-
#define YR_API EXTERNC __declspec(dllimport)
73-
#define YR_DEPRECATED_API EXTERNC __declspec(deprecated)
74-
#define YR_DEPRECATED __declspec(deprecated)
72+
#define YR_API EXTERNC __declspec(dllimport)
73+
#define YR_DEPRECATED_API EXTERNC __declspec(deprecated)
74+
#define YR_DEPRECATED(statement) __declspec(deprecated) statement
7575
#endif
7676
#else
77-
#define YR_API EXTERNC
78-
#define YR_DEPRECATED_API EXTERNC
79-
#define YR_DEPRECATED
77+
#define YR_API EXTERNC
78+
#define YR_DEPRECATED_API EXTERNC
79+
#define YR_DEPRECATED(statement) statement
8080
#endif
8181
#else
8282
#if __GNUC__ >= 4
83-
#define YR_API EXTERNC __attribute__((visibility("default")))
84-
#define YR_DEPRECATED_API YR_API __attribute__((deprecated))
85-
#define YR_DEPRECATED __attribute__((deprecated))
83+
#define YR_API EXTERNC __attribute__((visibility("default")))
84+
#define YR_DEPRECATED_API YR_API __attribute__((deprecated))
85+
#define YR_DEPRECATED(statement) statement __attribute__((deprecated))
8686
#else
87-
#define YR_API EXTERNC
88-
#define YR_DEPRECATED_API EXTERNC
89-
#define YR_DEPRECATED
87+
#define YR_API EXTERNC
88+
#define YR_DEPRECATED_API EXTERNC
89+
#define YR_DEPRECATED(statement) statement
9090
#endif
9191
#endif
9292

0 commit comments

Comments
 (0)