Gamoshi: Remove and update some bid response properties (prebid#3806)

* Add support for multi-format ad units. Add favoredMediaType property to params.

* Add tests for gdpr consent.

* Add adId to outbids

* Modify media type resolving

* Refactor multi-format ad units handler.

* Remove adId from bid response

* Add DEFAULT_TTL const for ttl property

* Modify TTL const to 360

Author: sa1omon

modules/gamoshiBidAdapter.js

@@ -11,6 +11,8 @@ const ENDPOINTS = {
   'gambid': 'https://rtb.gamoshi.io',
 };
 
+const DEFAULT_TTL = 360;
+
 export const helper = {
   getTopFrame: function () {
     try {
@@ -114,7 +116,7 @@ export const spec = {
 
       if (mediaTypes && mediaTypes.video) {
         if (!hasFavoredMediaType || params.favoredMediaType === VIDEO) {
-          const playerSize = mediaTypes.video.playerSize;
+          const playerSize = mediaTypes.video.playerSize || sizes;
           const videoImp = Object.assign({}, imp, {
             video: {
               w: playerSize ? playerSize[0][0] : 300,
@@ -150,18 +152,15 @@ export const spec = {
 
     bids.forEach(bid => {
       const outBid = {
-        adId: bidRequest.bidRequest.adUnitCode,
         requestId: bidRequest.bidRequest.bidId,
         cpm: bid.price,
         width: bid.w,
         height: bid.h,
-        ttl: 60 * 10,
-        creativeId: bid.crid,
+        ttl: DEFAULT_TTL,
+        creativeId: bid.crid || bid.adid,
         netRevenue: true,
         currency: bid.cur || response.cur,
-        adUnitCode: bidRequest.bidRequest.adUnitCode,
         mediaType: helper.getMediaType(bid)
-
       };
 
       if (utils.deepAccess(bidRequest.bidRequest, 'mediaTypes.' + outBid.mediaType)) {

test/spec/modules/gamoshiBidAdapter_spec.js

@@ -329,6 +329,8 @@ describe('GamoshiAdapter', function () {
       ]
     };
 
+    const TTL = 360;
+
     it('returns an empty array on missing response', function () {
       let response;
 
@@ -345,13 +347,12 @@ describe('GamoshiAdapter', function () {
       const response = spec.interpretResponse({body: rtbResponse}, {bidRequest: bannerBidRequest});
       expect(Array.isArray(response)).to.equal(true);
       expect(response.length).to.equal(1);
-
       const ad0 = response[0];
       expect(ad0.requestId).to.equal(bannerBidRequest.bidId);
       expect(ad0.cpm).to.equal(rtbResponse.seatbid[1].bid[0].price);
       expect(ad0.width).to.equal(rtbResponse.seatbid[1].bid[0].w);
       expect(ad0.height).to.equal(rtbResponse.seatbid[1].bid[0].h);
-      expect(ad0.ttl).to.equal(60 * 10);
+      expect(ad0.ttl).to.equal(TTL);
       expect(ad0.creativeId).to.equal(rtbResponse.seatbid[1].bid[0].crid);
       expect(ad0.netRevenue).to.equal(true);
       expect(ad0.currency).to.equal(rtbResponse.seatbid[1].bid[0].cur || rtbResponse.cur || 'USD');
@@ -364,13 +365,12 @@ describe('GamoshiAdapter', function () {
       const response = spec.interpretResponse({body: rtbResponse}, {bidRequest: videoBidRequest});
       expect(Array.isArray(response)).to.equal(true);
       expect(response.length).to.equal(1);
-
       const ad0 = response[0];
       expect(ad0.requestId).to.equal(videoBidRequest.bidId);
       expect(ad0.cpm).to.equal(rtbResponse.seatbid[0].bid[0].price);
       expect(ad0.width).to.equal(rtbResponse.seatbid[0].bid[0].w);
       expect(ad0.height).to.equal(rtbResponse.seatbid[0].bid[0].h);
-      expect(ad0.ttl).to.equal(60 * 10);
+      expect(ad0.ttl).to.equal(TTL);
       expect(ad0.creativeId).to.equal(rtbResponse.seatbid[0].bid[0].crid);
       expect(ad0.netRevenue).to.equal(true);
       expect(ad0.currency).to.equal(rtbResponse.seatbid[0].bid[0].cur || rtbResponse.cur || 'USD');