Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s390x Compatibility #250

Closed
xreip opened this issue Mar 4, 2025 · 7 comments
Closed

s390x Compatibility #250

xreip opened this issue Mar 4, 2025 · 7 comments
Labels
enhancement New feature or request

Comments

@xreip
Copy link

xreip commented Mar 4, 2025

Hi,

Would you consider adding a linux/s390x build in your CI/CD ?

I'm currently considering using victorialogs and victoriametrics on this plateform (they both compile on that arch). But i can't really exploit them since the Grafana datasources aren't compatible.

I understand this arch is niche but there's also so few tools easily available...

(Should i create an issue for victoriametrics datasource too ? Strangely the vm plugin "works" while vl doesn't, i guess it falls back to prometheus...)

Thanks

@dmitryk-dk dmitryk-dk added the enhancement New feature or request label Mar 4, 2025
@dmitryk-dk
Copy link
Contributor

Hi @xreip ! I asked in the issue to add support for this platform/arc
grafana/grafana-plugin-sdk-go#1257

If guys will add the support of the mentioned platform, I will update the SDK version.
If for some reason my proposition will be declined we will think how to implement our mage build file

@dmitryk-dk
Copy link
Contributor

Hi @xreip ! I built the plugin with the patched SDK on my local machine, how to share the archive with you?

Image

You can check to see if would it work on your machine

@xreip
Copy link
Author

xreip commented Mar 7, 2025

Hi @dmitryk-dk ! Thanks that's really nice !

I didn't know you depend on the grafana sdk for that.

I ended just compiling the plugin backend from source on the s390x machine. Installed the plugin from release and then :

  • Placed the s390x binary with the correct name in the folder
  • removed the MANIFEST file,
  • added the plugin as unsigned trusted in grafana config

We've been ingesting millions of logs in VL since yesterday through opentelemetry collector. Really happy with how it goes.
Querying with grafana plugin works just fine and we didn't have any issue.

Does your build would bring anything more ? I happily take the compilation full command tho 😁

If you could put the s390x binary in futur releases that would be very nice, but i understand it's a bit more complicated than i thought.

Thank you !

@dmitryk-dk
Copy link
Contributor

Hi @dmitryk-dk ! Thanks that's really nice !

I didn't know you depend on the grafana sdk for that.

I ended just compiling the plugin backend from source on the s390x machine. Installed the plugin from release and then :

  • Placed the s390x binary with the correct name in the folder
  • removed the MANIFEST file,
  • added the plugin as unsigned trusted in grafana config

We've been ingesting millions of logs in VL since yesterday through opentelemetry collector. Really happy with how it goes. Querying with grafana plugin works just fine and we didn't have any issue.

Does your build would bring anything more ? I happily take the compilation full command tho 😁

If you could put the s390x binary in futur releases that would be very nice, but i understand it's a bit more complicated than i thought.

Thank you !

Before we started to sign the plugin, we used our own make files and built for any platform.
But when we decided to sign the plugin, we would need to switch to the mage build file from the SDK.
Right now, the mage sdk doesn't support your platform and I created an issue.

To make some additional build is not a big problem, but for the sign process, it should be built via the mage

@dmitryk-dk
Copy link
Contributor

Hi @xreip ! The support was added only for victorialogs datasource, the same will be added to the victoriametrics datasource.
Please check this release.

I am not closing the issue while we add support to the victoriametrics datasource

@xreip
Copy link
Author

xreip commented Mar 14, 2025

Hello @dmitryk-dk ,

Amazing !

Thank you very much

@dmitryk-dk
Copy link
Contributor

Hi! I think we can close this issue because the build was enabled in the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants