Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question: add the ability to change serviceSpec (not only ingress) in k8s-stack #2091

Open
yuvalavidor opened this issue Mar 28, 2025 · 2 comments
Labels
question Further information is requested

Comments

@yuvalavidor
Copy link

Chart name and version, where you feel a lack of requested feature
chart: victoria-metrics-k8s-stack
version: v0.39.4

Is your feature request related to a problem? Please describe.
I wouldnt say its a problem, but I want to be able to add/change annotations for the services the VMcluster CRD is creating, specifically vminsert so i can create a NLB using a loadBalancer service and the AWS controller

Describe the solution you'd like
I would like to see something like:

vmcluster:
    vminsert:
       serviceSpec:
          type:
          extraAnnotations
@AndrewChubatiuk
Copy link
Collaborator

as it's mentioned in docs for chart's vmcluster.spec param you can get a list of all available for vmcluster.spec params here. annotations for vminsert can be added using this config

vmcluster:
  spec:
    vminsert:
      serviceSpec:
        metadata:
          annotations:
            some-key: some-value

@AndrewChubatiuk AndrewChubatiuk changed the title feature: add the ability to change serviceSpec (not only ingress) in k8s-stack question: add the ability to change serviceSpec (not only ingress) in k8s-stack Apr 2, 2025
@AndrewChubatiuk AndrewChubatiuk added question Further information is requested and removed waiting for release labels Apr 3, 2025
@AndrewChubatiuk
Copy link
Collaborator

hey @yuvalavidor
have you solved this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants