Skip to content

Commit 386e860

Browse files
logs: support .Values.sevice.extraPorts. fixes #2111
1 parent 979ba40 commit 386e860

File tree

5 files changed

+15
-6
lines changed

5 files changed

+15
-6
lines changed

charts/victoria-logs-single/CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
## Next release
22

33
- updated common dependency 0.0.39 -> 0.0.42
4+
- add .Values.service.extraPorts. See [this issue](https://github.com/VictoriaMetrics/helm-charts/issues/2111).
45

56
## 0.9.3
67

charts/victoria-logs-single/Chart.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ type: application
33
appVersion: v1.16.0
44
description: Victoria Logs Single version - high-performance, cost-effective and scalable logs storage
55
name: victoria-logs-single
6-
version: 0.9.3
6+
version: 0.9.4
77
sources:
88
- https://github.com/VictoriaMetrics/helm-charts
99
icon: https://avatars.githubusercontent.com/u/43720803?s=200&v=4

charts/victoria-logs-single/templates/server-service.yaml

+6
Original file line numberDiff line numberDiff line change
@@ -58,5 +58,11 @@ spec:
5858
{{- with $service.nodePort }}
5959
nodePort: {{ . }}
6060
{{- end }}
61+
{{- range $service.extraPorts }}
62+
- name: {{ .name }}
63+
port: {{ .port }}
64+
protocol: {{ .protocol | default "TCP" }}
65+
targetPort: {{ .targetPort }}
66+
{{- end }}
6167
selector: {{ include "vm.selectorLabels" $ctx | nindent 4 }}
6268
{{- end }}

charts/victoria-logs-single/values.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -286,6 +286,8 @@ server:
286286
# nodePort: 30000
287287
# -- Service type
288288
type: ClusterIP
289+
# -- Extra service ports
290+
extraPorts: []
289291
# -- Service external traffic policy. Check [here](https://kubernetes.io/docs/tasks/access-application-cluster/create-external-load-balancer/#preserving-the-client-source-ip) for details
290292
externalTrafficPolicy: ""
291293
# -- Health check node port for a service. Check [here](https://kubernetes.io/docs/tasks/access-application-cluster/create-external-load-balancer/#preserving-the-client-source-ip) for details

charts/victoria-metrics-cluster/templates/_helpers.tpl

+5-5
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@
158158

159159
{{- define "vmselect.ports" -}}
160160
{{- $service := .service }}
161-
{{- $extraArgs := .extraArgs }}
161+
{{- $extraArgs := .extraArgs -}}
162162
- name: http
163163
port: {{ $service.servicePort }}
164164
protocol: TCP
@@ -179,15 +179,15 @@
179179

180180
{{- define "vminsert.ports" -}}
181181
{{- $service := .service }}
182-
{{- $extraArgs := .extraArgs }}
182+
{{- $extraArgs := .extraArgs -}}
183183
- name: http
184184
port: {{ $service.servicePort }}
185185
protocol: TCP
186186
targetPort: {{ $service.targetPort }}
187187
{{- range $service.extraPorts }}
188188
- name: {{ .name }}
189189
port: {{ .port }}
190-
protocol: TCP
190+
protocol: {{ .protocol | default "TCP" }}
191191
targetPort: {{ .targetPort }}
192192
{{- end }}
193193
{{- with $extraArgs.clusternativeListenAddr }}
@@ -236,7 +236,7 @@
236236
{{- end -}}
237237

238238
{{- define "vmstorage.ports" -}}
239-
{{- $service := .service }}
239+
{{- $service := .service -}}
240240
- port: {{ $service.servicePort }}
241241
targetPort: http
242242
protocol: TCP
@@ -258,7 +258,7 @@
258258
{{- end -}}
259259

260260
{{- define "vmauth.ports" -}}
261-
{{- $service := .service }}
261+
{{- $service := .service -}}
262262
- port: {{ $service.servicePort }}
263263
targetPort: http
264264
protocol: TCP

0 commit comments

Comments
 (0)