-
Notifications
You must be signed in to change notification settings - Fork 16
fix ad hoc filter replace bug #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ad hoc filter replace bug #170
Conversation
@dmitryk-dk @Loori-R this looks like a nasty bug. Would appreciate your review and a set of tests to verify the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good tests are failed because one type was not imported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@yincongcyincong, thank you for your contribution! |
fix #167