Skip to content

annotation queries do not respect Custom query parameters #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hagen1778 opened this issue Aug 29, 2023 · 2 comments
Closed

annotation queries do not respect Custom query parameters #95

hagen1778 opened this issue Aug 29, 2023 · 2 comments
Assignees
@Loori-R
Labels
bug Something isn't working TBD

Comments

@hagen1778
Copy link
Contributor

To reproduce:
Configure VM datasource with custom query params:
image

All queries now supposed to filter metrics with job=vmalert.

Try plotting a panel to verify:
image

it works.

Add an annotation query:
image

Try plotting it on the panel:
image

It shows unflitered data.
@hagen1778 hagen1778 added bug Something isn't working TBD labels Aug 29, 2023
Loori-R added a commit that referenced this issue Aug 31, 2023
@Loori-R
fix: handle custom query params in annotation queries (#95)
3a56c3e
@Loori-R Loori-R mentioned this issue Aug 31, 2023
Merged
@hagen1778
Copy link
Contributor Author

@Loori-R thanks for PR! Can we make a release?

@Loori-R Loori-R mentioned this issue Sep 13, 2023
Merged
@Loori-R
Copy link
Contributor

Loori-R commented Sep 22, 2023

The bugfix has been included in victoriametrics-datasource v0.4.0.

@Loori-R Loori-R closed this as completed Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Loori-R Loori-R

Labels
bug Something isn't working TBD
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hagen1778 @Loori-R