Skip to content

feat(flutter_plugin): conditional platform support #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 30, 2021
Merged

feat(flutter_plugin): conditional platform support #195

merged 13 commits into from
Sep 30, 2021

Conversation

marcossevilla
Copy link
Contributor

Description

  • Update flutter_plugin mason bundle to the latest version with conditional folder support.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@marcossevilla marcossevilla added the refactor A code change that neither fixes a bug nor add a feature label Sep 28, 2021
@marcossevilla marcossevilla self-assigned this Sep 28, 2021
@felangel
Copy link
Contributor

shouldn't we add flags for each platform so that developers can specify which platforms they want? Currently all platforms will just default to false.

@marcossevilla
Copy link
Contributor Author

shouldn't we add flags for each platform so that developers can specify which platforms they want? Currently all platforms will just default to false.

should be good now, let me know what you think. 👍

@felangel felangel changed the title refactor: update flutter plugin bundle feat(flutter_plugin): conditional platform support Sep 30, 2021
@felangel felangel merged commit ea878c3 into main Sep 30, 2021
@felangel felangel deleted the refactor/update-flutter-plugin-bundle branch September 30, 2021 21:06
@felangel felangel mentioned this pull request Sep 30, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

@jorgecoca jorgecoca Awaiting requested review from jorgecoca

Assignees

@marcossevilla marcossevilla

Labels
refactor A code change that neither fixes a bug nor add a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcossevilla @felangel