Skip to content

Commit ba76432

Browse files
krajoramaVandit1604
authored andcommitted
fix(remotewrite2): do not overwrite help text with unit in enqueue
While testing POC for grafana/mimir#9072 I saw no unit or help metadata. Our test env: https://github.com/grafana/mimir/tree/main/development/mimir-monolithic-mode doesn't have units, so that was empty and cleared the help due to this bug. Signed-off-by: György Krajcsovits <[email protected]>
1 parent c1df738 commit ba76432

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

storage/remote/queue_manager.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -1923,7 +1923,7 @@ func populateV2TimeSeries(symbolTable *writev2.SymbolsTable, batch []timeSeries,
19231923
if d.metadata != nil {
19241924
pendingData[nPending].Metadata.Type = writev2.FromMetadataType(d.metadata.Type)
19251925
pendingData[nPending].Metadata.HelpRef = symbolTable.Symbolize(d.metadata.Help)
1926-
pendingData[nPending].Metadata.HelpRef = symbolTable.Symbolize(d.metadata.Unit)
1926+
pendingData[nPending].Metadata.UnitRef = symbolTable.Symbolize(d.metadata.Unit)
19271927
nPendingMetadata++
19281928
}
19291929

0 commit comments

Comments
 (0)