Skip to content

The Legend of Heroes: Trails of Cold Steel II (748490) #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks done
enimog opened this issue Dec 24, 2018 · 10 comments
Open
2 tasks done

The Legend of Heroes: Trails of Cold Steel II (748490) #2134

enimog opened this issue Dec 24, 2018 · 10 comments
Labels
Game compatibility - Unofficial Games not expected to work without issues .NET Uses the .NET framework XAudio2 Uses the XAudio2 subsystem

Comments

@enimog
Copy link

enimog commented Dec 24, 2018

Compatibility Report

  • Name of the game with compatibility issues: The Legend of Heroes: Trails of Cold Steel II
  • Steam AppID of the game: 748490

System Information

I confirm:

  • that I haven't found an existing compatibility report for this game.
  • that I have checked whether there are updates for my system available.

Symptoms

The following issues apply for both The Legend of Heroes: Trails of Cold Steel and The Legend of Heroes: Trails of Cold Steel II:

  • When installing the game from the steam launcher, it tries to install MS .NET 4.0 (for cold steel I) / .NET 4.7 (for cold steel II). This break the game and make them unable to launch. In fact you get the same error as reported here : The Legend of Heroes: Trails of Cold Steel (538680) fails to launch #1048 . To launch the game, you have to use wine-mono
  • The intro video is not displayed (the sound plays but the video is a black screen). This is a case of a missing video codec. Installing k-lite codec pack MEGA in the prefix and disabling winegstreamer fix the issue for me.

The following issues apply for The Legend of Heroes: Trails of Cold Steel II only:

  • It need protontricks 748490 quartz to start without crashing
  • When starting a new game, the player is asked to load a save from the previous game (The Legend of Heroes: Trails of Cold Steel). The game cannot find the save as the save path is not shared between prefixes. The location of the game saves are inside steamapps/compatdata/748490/pfx/drive_c/users/steamuser/Saved Games/Falcom/... .This could be fixed by making the 'Saved Games' folder a symlink to a folder inside the home folder in the same way as wine does for desktop/my documents/my music/etc.

Once these issues have been addressed, it will be possible to mark this series as platinum on protondb as both games work perfectly from the start to the end if they manage to start.

Reproduction

Try to launch the game after downloading it from the steam app.

@kisak-valve kisak-valve added Game compatibility - Unofficial Games not expected to work without issues .NET Uses the .NET framework labels Dec 24, 2018
@kisak-valve
Copy link
Member

The Legend of Heroes: Trails of Cold Steel II (748490)

Issue transferred from #2677.
@goldhawlk posted on 2019-05-12T13:55:54:

Whitelist Request

  • Name of the game to be whitelisted: The Legend of Heroes: Trails of Cold Steel II
  • Steam AppID of the game: 748490

System Information

I confirm:

  • that pressing the Play button in the Steam client is sufficient.
  • that runtime config options are necessary to run the game.
  • that no workarounds other than PROTON_* env variables are necessary.

Issues

  • I haven't experienced any issues.
  • There are no issues left open for this game.
  • Although I consider the gaming experience equal to Windows there are remaining issues:

@kisak-valve
Copy link
Member

Hello @enimog, can you check if this game (Cold Steel II) has any issues with Proton 4.2-3 that would block it from being whitelisted?

@kisak-valve kisak-valve added the Need Retest Request to retest an issue with vanilla Proton label May 12, 2019
@enimog
Copy link
Author

enimog commented May 12, 2019

Tested with a clean prefix (I deleted the old one) and Proton 4.2-3, here are the result I get:

  • The configuration tool that comes with the game start properly and I can edit settings no problem.
  • With the default configuration, I see some wierd glitch when the opening video start, might be an issue with my system or maybe not... VLC is saying the codec used for the intro video is "DivX MPEG-4 Video (DX50)". Is that supported by proton right now? the sound is playing in the background properly and if I hit any key the game skip the intro video and goes to the main menu. From there, I am able to load one of my saves and play the game normally. By normally I mean that everything is working as expected. Using the configuration tool I can disable all videos from playing and this way I don't see any wierd stuff.

@kisak-valve kisak-valve removed the Need Retest Request to retest an issue with vanilla Proton label May 12, 2019
@RAMChYLD
Copy link

RAMChYLD commented Sep 8, 2021

With the latest version of proton experimental video is not playing and installing xvid does not resolve the issue anymore. Now it shows a test pattern with a counter and static.

@zany130
Copy link

zany130 commented Jan 5, 2022

unplayable on recent versions of proton constantly crashes and audio randomly breaks after a few hours of play ( audio stops playing then the game crashes when it goes to load a new scene)
steam-Trails of Cold Steel II.log

@kisak-valve kisak-valve added the XAudio2 Uses the XAudio2 subsystem label Jan 5, 2022
@zany130
Copy link

zany130 commented Jan 27, 2022

still getting this issue thought I would post a newer proton log and sys info since I forgot to for my previous post

@zany130
Copy link

zany130 commented Feb 22, 2022

if anyone runs into this issue on Linux I fixed it by disabling the audio patches in senpatcher. Game works flawlessly (including videos) now on proton 7.0-1

@rvalles
Copy link

rvalles commented Feb 23, 2022

if anyone runs into this issue on Linux I fixed it by disabling the audio patches in senpatcher.

That's the first thing I tried. No dice.

Audio issue will happen a lot or not at all depending on the area, which is what I suspect you're experiencing.

@zany130
Copy link

zany130 commented Feb 23, 2022

yeah may have prematurely called it fixed by disabling the audio patches in senpatcher got it to happen again with no patches.
seems really busy area's with a lot of different sound sources ( like in front of barahard cathedral where there sfx from the water fountain and the npc footsteps from walking around) is more likely to trigger the bug. and causes warn:seh:OutputDebugStringA "Command buffer maxed out so refused execution of command: 63504 / 65536 bytes\n" to appear in the proton log at the same time the audio loss happens which AdmiralCurtiss from senpatcher mentioned might be related

@AdmiralCurtiss
Copy link

To clarify, that message is from CS2 itself, not Proton or XAudio2. As far as I understand from reverse-engineering anyway, the way the audio logic in CS2 works is that there's a command ringbuffer that the main thread pushes commands into (play SFX, play voice, switch BGM, etc.), and a separate audio thread then processes these into actual XAudio2 calls.

The log message is repeated a lot after the bug triggers, with the same amount of bytes every time, which leads me to believe that the audio thread either dies or deadlocks on Proton and thus no new commands are processed and removed from the buffer anymore, and the main thread stops pushing new ones because the ringbuffer is full, printing the message in the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Game compatibility - Unofficial Games not expected to work without issues .NET Uses the .NET framework XAudio2 Uses the XAudio2 subsystem
Projects
None yet
Development

No branches or pull requests

7 participants