use link_libraries in try_compile instead of pragma lib in cpp

malytomas · zpostfacto · commit 43fd09cc4f1c · 2024-09-09T12:09:56.000-07:00
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -88,7 +88,7 @@ if (WIN32)
 		#
 		# Check whether BCrypt can be used with this SDK version
 		#
-		try_compile(BCRYPT_AVAILABLE "${CMAKE_CURRENT_BINARY_DIR}/tryCompile" SOURCES "${CMAKE_CURRENT_LIST_DIR}/cmake/tryCompileTestBCrypt.cpp" OUTPUT_VARIABLE BCRYPT_AVAILABILITY_TEST_MESSAGES)
+		try_compile(BCRYPT_AVAILABLE "${CMAKE_CURRENT_BINARY_DIR}/tryCompile" SOURCES "${CMAKE_CURRENT_LIST_DIR}/cmake/tryCompileTestBCrypt.cpp" LINK_LIBRARIES bcrypt OUTPUT_VARIABLE BCRYPT_AVAILABILITY_TEST_MESSAGES)
 		if (NOT BCRYPT_AVAILABLE)
 			message(STATUS ${BCRYPT_AVAILABILITY_TEST_MESSAGES})
 			message(FATAL_ERROR "You're on Windows but BCrypt seems to be unavailable, you will need OpenSSL")
diff --git a/cmake/tryCompileTestBCrypt.cpp b/cmake/tryCompileTestBCrypt.cpp
@@ -1,7 +1,6 @@
 #include <Windows.h>
 #include <bcrypt.h>
 #include <cstdio>
-#pragma comment(lib, "bcrypt.lib")
 
 int main(int, char **)
 {

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ if (WIN32)`
`88`	`88`	`#`
`89`	`89`	`# Check whether BCrypt can be used with this SDK version`
`90`	`90`	`#`
`91`		`- try_compile(BCRYPT_AVAILABLE "${CMAKE_CURRENT_BINARY_DIR}/tryCompile" SOURCES "${CMAKE_CURRENT_LIST_DIR}/cmake/tryCompileTestBCrypt.cpp" OUTPUT_VARIABLE BCRYPT_AVAILABILITY_TEST_MESSAGES)`
	`91`	`+ try_compile(BCRYPT_AVAILABLE "${CMAKE_CURRENT_BINARY_DIR}/tryCompile" SOURCES "${CMAKE_CURRENT_LIST_DIR}/cmake/tryCompileTestBCrypt.cpp" LINK_LIBRARIES bcrypt OUTPUT_VARIABLE BCRYPT_AVAILABILITY_TEST_MESSAGES)`
`92`	`92`	`if (NOT BCRYPT_AVAILABLE)`
`93`	`93`	`message(STATUS ${BCRYPT_AVAILABILITY_TEST_MESSAGES})`
`94`	`94`	`message(FATAL_ERROR "You're on Windows but BCrypt seems to be unavailable, you will need OpenSSL")`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,6 @@`
`1`	`1`	`#include <Windows.h>`
`2`	`2`	`#include <bcrypt.h>`
`3`	`3`	`#include <cstdio>`
`4`		`-#pragma comment(lib, "bcrypt.lib")`
`5`	`4`
`6`	`5`	`int main(int, char **)`
`7`	`6`	`{`