Merge pull request #57 from UBC-MDS/ken_ms4

edited dependencies and added RSelenium::remoteDriver import in nba_s…

Author: AndresPitta

NAMESPACE

@@ -8,6 +8,7 @@ import(dplyr)
 import(forcats)
 import(ggplot2)
 import(scales)
+importFrom(RSelenium,remoteDriver)
 importFrom(forcats,fct_reorder)
 importFrom(magrittr,"%>%")
 importFrom(readr,read_csv)

R/nba_scraper.R

@@ -22,6 +22,7 @@
 #' @importFrom rvest html_nodes
 #' @importFrom rvest html_text
 #' @importFrom tibble as_tibble
+#' @importFrom RSelenium remoteDriver
 #'
 #' @return A tibble of scraped ESPN NBA data
 #'

README.Rmd

@@ -216,6 +216,28 @@ For a more detailed understanding of the functions and their use cases, please r
 
 To do testing of the package functions, please refer to the instructions found in the [README.md located at the testing subdirectory folder](https://github.com/UBC-MDS/rsketball/blob/master/tests/README.md). 
 
+## Dependencies
+
+dplyr>=0.8.3
+
+forcats>=0.5.0
+
+ggplot2>=3.2.1
+
+magrittr>=1.5
+
+readr>=1.3.1
+
+rlang>=0.4.2
+
+rvest>=0.3.4
+
+scales>=1.1.0
+
+tibble>=2.1.3
+
+RSelenium>=1.7.7
+
 ## R Ecosystem
 
 This `rsketball` package aims to further gain understanding of ESPN NBA data and does not have a specific fit to the R ecosystem. There are currently some other library packages such as [`nbastatR`](https://www.rdocumentation.org/packages/nbastatR/versions/0.1.10131) that take data from other sources (NBA Stats API, Basketball Insiders, Basketball-Reference, HoopsHype, and RealGM), but no package that we currently know of takes data from ESPN NBA specifically.

README.md

@@ -297,6 +297,29 @@ To do testing of the package functions, please refer to the instructions
 found in the [README.md located at the testing subdirectory
 folder](https://github.com/UBC-MDS/rsketball/blob/master/tests/README.md).
 
+Dependencies
+------------
+
+dplyr>=0.8.3
+
+forcats>=0.5.0
+
+ggplot2>=3.2.1
+
+magrittr>=1.5
+
+readr>=1.3.1
+
+rlang>=0.4.2
+
+rvest>=0.3.4
+
+scales>=1.1.0
+
+tibble>=2.1.3
+
+RSelenium>=1.7.7
+
 R Ecosystem
 -----------