Skip to content

Merge Scripts: Warn about potential lost changes #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Myaamori opened this issue Feb 6, 2020 · 0 comments
Open

Merge Scripts: Warn about potential lost changes #6

Myaamori opened this issue Feb 6, 2020 · 0 comments

Comments

@Myaamori
Copy link
Collaborator

Myaamori commented Feb 6, 2020

There are at least two cases that may lead to changes being lost:

  1. Unimporting lines that were changed without first exporting the changes to the source files
  2. Exporting changes when the source file has been changed since the lines were originally imported
  3. Any others?

2 can be solved easily enough by hashing the source file on import and export and comparing the two. Not sure about 1 (hashing the subtitles object?).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Myaamori