Skip to content

Commit d0a5763

Browse files
committed
Percentage value fix
1 parent 7fd3419 commit d0a5763

File tree

2 files changed

+26
-5
lines changed

2 files changed

+26
-5
lines changed

src/ExCSS.Tests/PropertyTests/OpacityPropertyTests.cs

+25-4
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,30 @@ public void OpacityPercentLegal()
1111
Assert.Equal("opacity", property.Name);
1212
Assert.False(property.IsImportant);
1313
Assert.IsType<OpacityProperty>(property);
14-
var concrete = (OpacityProperty)property;
15-
Assert.False(concrete.IsInherited);
16-
Assert.True(concrete.HasValue);
17-
Assert.Equal("50%", concrete.Value);
14+
var result = (OpacityProperty)property;
15+
Assert.False(result.IsInherited);
16+
Assert.True(result.HasValue);
17+
Assert.Equal("50%", result.Value);
18+
}
19+
20+
21+
[Fact]
22+
public void OpacityVarianceTests()
23+
{
24+
var property = ParseDeclaration("opacity: 50%");
25+
var result = (OpacityProperty)property;
26+
Assert.Equal("50%", result.Value);
27+
28+
property = ParseDeclaration("opacity: .50");
29+
result = (OpacityProperty)property;
30+
Assert.Equal("50%", result.Value);
31+
32+
property = ParseDeclaration("opacity: 1");
33+
result = (OpacityProperty)property;
34+
Assert.Equal("100%", result.Value);
35+
36+
property = ParseDeclaration("opacity: 0");
37+
result = (OpacityProperty)property;
38+
Assert.Equal("0%", result.Value);
1839
}
1940
}

src/ExCSS/Extensions/ValueExtensions.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ public static Length ToLength(this FontSize fontSize)
111111
try
112112
{
113113
var number = token.Value;
114-
var percentage = number / 100;
114+
var percentage = number * 100;
115115
return new Percent(percentage);
116116
}
117117
catch

0 commit comments

Comments
 (0)