Skip to content

Support the Mold Linker #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Twon opened this issue Jul 18, 2023 · 4 comments
Closed

Support the Mold Linker #179

Twon opened this issue Jul 18, 2023 · 4 comments
Assignees
Labels
build Issue related to build system infrastructure good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Twon
Copy link
Owner

Twon commented Jul 18, 2023

There is now a Conan package for Mold: https://conan.io/center/mold. This should be added to the build.

@Twon Twon added help wanted Extra attention is needed good first issue Good for newcomers build Issue related to build system infrastructure labels Jul 18, 2023
@jakeheke75
Copy link
Collaborator

Hi Antony, I apologize for the newbie question. Is this just a matter of adding the Mold package and its dependencies to the conanfile.py or there is more? Thanks in advance!
Cheers,
Gianmario

@jakeheke75 jakeheke75 self-assigned this Jul 18, 2023
@jakeheke75
Copy link
Collaborator

Hi Antony,
Just for information: the Mold linker can be used with the Conan recipe only if build_type == "Release"
conan-io/conan-center-index#11536 (comment)
This is the Conan recipe source code:
https://github.com/conan-io/conan-center-index/blob/1ede4d191660c9fcc0b7848744a8bcfb14cff626/recipes/mold/1.3.1/conanfile.py#L23-L25
I didn't expect that 😞

@Twon
Copy link
Owner Author

Twon commented Sep 23, 2023

Hey Gainmario,

I think that is OK, it does not mean it will not work with debug builds, but it does mean that you have to specify release configuration in the conanfile settings so that in a debug build it uses the release build of Mold. As this is a build tool that is kind of what you want anyway (as it's not library code compiled into your library/application)

Does that make sense?

@jakeheke75
Copy link
Collaborator

Hello Antony,
Yes, it does make sense, sorry but I am a newbie also with Conan 😄
it seemed strange to me to change the self.settings.build_type in conanfile.py just to accommodate the recipe rule of mold but now after your explanation I can see the reason.
I am drafting a PR, I will submit it as soon as I get a successful build.
Thanks,
Gianmario

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issue related to build system infrastructure good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants