Skip to content

Commit 636a6d9

Browse files
author
Dane Springmeyer
committed
alt workaround for nodejs/node-gyp#972 since npm-windows-upgrade broke node v0.10.x support
1 parent 4aaea74 commit 636a6d9

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
"node-pre-gyp"
4545
],
4646
"devDependencies": {
47+
"node-gyp": "^3.6.1",
4748
"aws-sdk": "2.x",
4849
"eslint": "3.5.0",
4950
"mocha": "3.x"

scripts/build-appveyor.bat

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,13 +48,6 @@ IF %NODE_MAJOR% GTR 0 ECHO node version greater than zero, not updating npm && G
4848

4949
powershell Set-ExecutionPolicy Unrestricted -Scope CurrentUser -Force
5050
IF %ERRORLEVEL% NEQ 0 GOTO ERROR
51-
CALL npm install --global --production npm-windows-upgrade
52-
IF %ERRORLEVEL% NEQ 0 GOTO ERROR
53-
REM https://ci.appveyor.com/project/Mapbox/node-sqlite3/build/1.0.500/job/n2y9fo4eg316db56#L289
54-
REM error C2373: '__pfnDliNotifyHook2': redefinition; different type modifiers
55-
REM at least 2.15.9 is needed: https://github.com/nodejs/node-gyp/issues/972#issuecomment-231055109
56-
CALL npm-windows-upgrade --npm-version 2.15.9 --no-dns-check --no-prompt
57-
IF %ERRORLEVEL% NEQ 0 GOTO ERROR
5851

5952
:SKIP_APPVEYOR_INSTALL
6053
IF /I "%msvs_toolset%"=="12" GOTO NODE_INSTALLED

0 commit comments

Comments
 (0)