Skip to content

Commit a085bcb

Browse files
committed
test: logger test now passes
1 parent 5bbc6c6 commit a085bcb

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

crates/c2pdf/src/lib/logging.rs

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
//! Module for logging on a separate thread
22
use std::{
3-
sync::{
4-
Arc, Mutex,
5-
},
3+
sync::{Arc, Mutex},
64
thread::{self, JoinHandle},
75
};
86
pub enum LoggerMessage {
@@ -56,12 +54,12 @@ impl Logger {
5654
self.tx.send(msg).unwrap()
5755
}
5856
/// Waits for all threads to finish
59-
pub fn finish(self) {
57+
pub fn finish(self) -> std::thread::Result<()> {
6058
// Logger thread should exit once it processes this signal
6159
self.tx.send(LoggerMessage::Abort).unwrap();
6260
let mut lock = self.handle.lock().unwrap();
6361
let handle = lock.take().unwrap();
64-
handle.join();
62+
handle.join()
6563
}
6664
}
6765

@@ -72,7 +70,7 @@ mod tests {
7270
fn it_works() {
7371
let logger = Logger::new(crossbeam_channel::unbounded());
7472
logger.log("Hello World!!!".into());
75-
logger.finish();
76-
assert!(false);
73+
_ = logger.finish();
74+
// assert!(false);
7775
}
7876
}

0 commit comments

Comments
 (0)